Xen devel - Feb 2006 - [PATCH] Repost - xm lists display and formatting

This patch displays the network-list/block-list/vtpm-list using the
''xm''
command. It supports the ''--long'' option.

Signed-off-by: Stefan Berger <stefanb@us.ibm.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> This patch displays the network-list/block-list/vtpm-list using the
''xm''
> command. It supports the ''--long'' option.
> 
> Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
Applied, thank you.

This will break xm-test.  Does anyone fancy fixing it up?  The
least-effort thing to do is change all of the calls to block-list and
network-list to become block-list --long and network-list --long, but
it would be better if we fixed the eyecatchers (where necessary) to work
with the new, formatted commands, and maybe added a few tests for
xyz-list --long as well.

And of course it would be nice to have tests for vtpm-list (after detecting
the presence of appropriate hardware, I guess).

Any volunteers?

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> 
> > This patch displays the network-list/block-list/vtpm-list using the
''xm''
> > command. It supports the ''--long'' option.
> > 
> > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> 
> Applied, thank you.
> 
> This will break xm-test.  Does anyone fancy fixing it up?  The
> least-effort thing to do is change all of the calls to block-list and
> network-list to become block-list --long and network-list --long, but
> it would be better if we fixed the eyecatchers (where necessary) to work
> with the new, formatted commands, and maybe added a few tests for
> xyz-list --long as well.
> 
> And of course it would be nice to have tests for vtpm-list (after detecting
> the presence of appropriate hardware, I guess).
> 
> Any volunteers?

Hi,

Three comments:

1) Changes like those introduced by this patch should be submitted with
corresponding tests in xm-test. We want to continue to use xm-test to
verify functionality.

2) The documentation - like man pages - should be updated along with the
new functionality. 

3) xm-test should be used to verify patches prior to submitting and
applying. 

Thanks,

Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

dsteklof@us.ltcfwd.linux.ibm.com wrote on 02/17/2006 02:00:15 PM:
> On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > 
> > > This patch displays the network-list/block-list/vtpm-list using
the
''xm''
> > > command. It supports the ''--long'' option.
> > > 
> > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > 
> > Applied, thank you.
> > 
> > This will break xm-test.  Does anyone fancy fixing it up?  The
> > least-effort thing to do is change all of the calls to block-list and
> > network-list to become block-list --long and network-list --long, but
> > it would be better if we fixed the eyecatchers (where necessary) to 
work
> > with the new, formatted commands, and maybe added a few tests for
> > xyz-list --long as well.
> > 
> > And of course it would be nice to have tests for vtpm-list (after 
detecting
> > the presence of appropriate hardware, I guess).
> > 
> > Any volunteers?
> 
> 
> Hi,
> 
> Three comments:
> 
> 1) Changes like those introduced by this patch should be submitted with
> corresponding tests in xm-test. We want to continue to use xm-test to
> verify functionality.
> 
> 2) The documentation - like man pages - should be updated along with the
> new functionality. 
> 
> 3) xm-test should be used to verify patches prior to submitting and
> applying. 
Sorry, I did not know about the dependency of this tool on the output of 
this command.

  Stefan
> 
> Thanks,
> 
> Dan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefan
Hi
Thanks for the xm-text initiative.

Did you test with xm-test (the whole suite of testx) on i386 and/or
x86_64 and/or VMX, before submitting the patches? Did they all work?

Dan is right, the doc also needs work.

woody
=============On Fri, 2006-02-17 at 11:00 -0800, Daniel Stekloff
wrote:
> On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > 
> > > This patch displays the network-list/block-list/vtpm-list using
the ''xm''
> > > command. It supports the ''--long'' option.
> > > 
> > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > 
> > Applied, thank you.
> > 
> > This will break xm-test.  Does anyone fancy fixing it up?  The
> > least-effort thing to do is change all of the calls to block-list and
> > network-list to become block-list --long and network-list --long, but
> > it would be better if we fixed the eyecatchers (where necessary) to
work
> > with the new, formatted commands, and maybe added a few tests for
> > xyz-list --long as well.
> > 
> > And of course it would be nice to have tests for vtpm-list (after
detecting
> > the presence of appropriate hardware, I guess).
> > 
> > Any volunteers?
> 
> 
> Hi,
> 
> Three comments:
> 
> 1) Changes like those introduced by this patch should be submitted with
> corresponding tests in xm-test. We want to continue to use xm-test to
> verify functionality.
> 
> 2) The documentation - like man pages - should be updated along with the
> new functionality. 
> 
> 3) xm-test should be used to verify patches prior to submitting and
> applying. 
> 
> Thanks,
> 
> Dan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
-- 
Sincerely,      Woody Marvel
IBM Linux Technology Center
Open Source Virtualization
email: marvel@us.ibm.com
503-578-3833   Beaverton, OR 97006
**********************************


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefan

But you still want the feature in xm-test?

wm
===============On Fri, 2006-02-17 at 14:17 -0500, Stefan Berger
wrote:
> 
> dsteklof@us.ltcfwd.linux.ibm.com wrote on 02/17/2006 02:00:15 PM:
> 
> > On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > > 
> > > > This patch displays the network-list/block-list/vtpm-list
using
> the ''xm''
> > > > command. It supports the ''--long'' option.
> > > > 
> > > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > > 
> > > Applied, thank you.
> > > 
> > > This will break xm-test.  Does anyone fancy fixing it up?  The
> > > least-effort thing to do is change all of the calls to block-list
> and
> > > network-list to become block-list --long and network-list --long,
> but
> > > it would be better if we fixed the eyecatchers (where necessary)
> to work
> > > with the new, formatted commands, and maybe added a few tests for
> > > xyz-list --long as well.
> > > 
> > > And of course it would be nice to have tests for vtpm-list (after
> detecting
> > > the presence of appropriate hardware, I guess).
> > > 
> > > Any volunteers?
> > 
> > 
> > Hi,
> > 
> > Three comments:
> > 
> > 1) Changes like those introduced by this patch should be submitted
> with
> > corresponding tests in xm-test. We want to continue to use xm-test
> to
> > verify functionality.
> > 
> > 2) The documentation - like man pages - should be updated along with
> the
> > new functionality. 
> > 
> > 3) xm-test should be used to verify patches prior to submitting and
> > applying.  
> 
> Sorry, I did not know about the dependency of this tool on the output
> of this command. 
> 
>   Stefan
> > 
> > Thanks,
> > 
> > Dan
> > 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
-- 
Sincerely,      Woody Marvel
IBM Linux Technology Center
Open Source Virtualization
email: marvel@us.ibm.com
503-578-3833   Beaverton, OR 97006
**********************************


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

xen-devel-bounces@lists.xensource.com wrote on 02/17/2006 02:54:21 PM:
> Stefan
> Hi
> Thanks for the xm-text initiative.
> 
> Did you test with xm-test (the whole suite of testx) on i386 and/or
> x86_64 and/or VMX, before submitting the patches? Did they all work?
I had tested it with xm-test ''block-list'' on x86. There were
no failures
on those block-device related test, but 8 PASSes. This time it got stuck 
in one of the test.

> 
> Dan is right, the doc also needs work.
I have just adapted the man page and will submit that later.

   Stefan
> 
> woody
> =============> On Fri, 2006-02-17 at 11:00 -0800, Daniel Stekloff wrote:
> > On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > > 
> > > > This patch displays the network-list/block-list/vtpm-list
using
the ''xm''
> > > > command. It supports the ''--long'' option.
> > > > 
> > > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > > 
> > > Applied, thank you.
> > > 
> > > This will break xm-test.  Does anyone fancy fixing it up?  The
> > > least-effort thing to do is change all of the calls to block-list
and
> > > network-list to become block-list --long and network-list --long,
but
> > > it would be better if we fixed the eyecatchers (where necessary)
to
work
> > > with the new, formatted commands, and maybe added a few tests for
> > > xyz-list --long as well.
> > > 
> > > And of course it would be nice to have tests for vtpm-list 
> (after detecting
> > > the presence of appropriate hardware, I guess).
> > > 
> > > Any volunteers?
> > 
> > 
> > Hi,
> > 
> > Three comments:
> > 
> > 1) Changes like those introduced by this patch should be submitted 
with
> > corresponding tests in xm-test. We want to continue to use xm-test to
> > verify functionality.
> > 
> > 2) The documentation - like man pages - should be updated along with 
the
> > new functionality. 
> > 
> > 3) xm-test should be used to verify patches prior to submitting and
> > applying. 
> > 
> > Thanks,
> > 
> > Dan
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> > 
> -- 
> Sincerely,      Woody Marvel
> IBM Linux Technology Center
> Open Source Virtualization
> email: marvel@us.ibm.com
> 503-578-3833   Beaverton, OR 97006
> **********************************
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

xen-devel-bounces@lists.xensource.com wrote on 02/17/2006 02:54:21 PM:
> Stefan
> Hi
> Thanks for the xm-text initiative.
> 
> Did you test with xm-test (the whole suite of testx) on i386 and/or
> x86_64 and/or VMX, before submitting the patches? Did they all work?
> 

Here''s now the output of a testrun on x86:

REASON: (7 nics) Console didn''t respond: probably crashed!
FAIL: 13_create_multinic_pos.test
REASON: ping loopback failed for size 65507. ping eth0 failed for size 
65507.
XFAIL: 02_network_local_ping_pos.test
REASON: Ping to dom0 failed for size 32767 65507.
XFAIL: 05_network_dom0_ping_pos.test
REASON: Ping failed for size 32767 65507.
XFAIL: 11_network_domU_ping_pos.test
REASON: /proc/cpuinfo says xend didn''t enforce dom0_cpus (2 != 1)
FAIL: 01_enforce_dom0_cpus_basic_pos.test
REASON: xm migrate returned invalid 256 != 0
FAIL: 01_migrate_localhost_pos.test

I think none of these errors is related to the xm changes regarding 
network-list or block-list.
I expect the consequences of the xm changes NOT to influence the test 
results on x86_64 or VMX - other challenges might be lurking there.

   Stefan
> Dan is right, the doc also needs work.
> 
> woody
> =============> On Fri, 2006-02-17 at 11:00 -0800, Daniel Stekloff wrote:
> > On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > > 
> > > > This patch displays the network-list/block-list/vtpm-list
using
the ''xm''
> > > > command. It supports the ''--long'' option.
> > > > 
> > > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > > 
> > > Applied, thank you.
> > > 
> > > This will break xm-test.  Does anyone fancy fixing it up?  The
> > > least-effort thing to do is change all of the calls to block-list
and
> > > network-list to become block-list --long and network-list --long,
but
> > > it would be better if we fixed the eyecatchers (where necessary)
to
work
> > > with the new, formatted commands, and maybe added a few tests for
> > > xyz-list --long as well.
> > > 
> > > And of course it would be nice to have tests for vtpm-list 
> (after detecting
> > > the presence of appropriate hardware, I guess).
> > > 
> > > Any volunteers?
> > 
> > 
> > Hi,
> > 
> > Three comments:
> > 
> > 1) Changes like those introduced by this patch should be submitted 
with
> > corresponding tests in xm-test. We want to continue to use xm-test to
> > verify functionality.
> > 
> > 2) The documentation - like man pages - should be updated along with 
the
> > new functionality. 
> > 
> > 3) xm-test should be used to verify patches prior to submitting and
> > applying. 
> > 
> > Thanks,
> > 
> > Dan
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> > 
> -- 
> Sincerely,      Woody Marvel
> IBM Linux Technology Center
> Open Source Virtualization
> email: marvel@us.ibm.com
> 503-578-3833   Beaverton, OR 97006
> **********************************
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefan Berger wrote:
> 
> xen-devel-bounces@lists.xensource.com wrote on 02/17/2006 02:54:21 PM:
> 
>  > Stefan
>  > Hi
>  > Thanks for the xm-text initiative.
>  >
>  > Did you test with xm-test (the whole suite of testx) on i386 and/or
>  > x86_64 and/or VMX, before submitting the patches? Did they all work?
>  >
Ewan, are you still running xm-test as part of your pre-commit
regression testing? Also, have you started running on hvm hw?
IIRC, Ian had mentioned that you were soon going to introduce
these in your testbed.

We''d like to see more of these bugs caught prior to commit,
and hoping to encourage all the developers out there to
please run as well...

thanks,
Nivedita

> Here''s now the output of a testrun on x86:
> 
> REASON: (7 nics) Console didn''t respond: probably crashed!
> FAIL: 13_create_multinic_pos.test
> REASON: ping loopback failed for size 65507. ping eth0 failed for size 
> 65507.
> XFAIL: 02_network_local_ping_pos.test
> REASON: Ping to dom0 failed for size 32767 65507.
> XFAIL: 05_network_dom0_ping_pos.test
> REASON: Ping failed for size 32767 65507.
> XFAIL: 11_network_domU_ping_pos.test
> REASON: /proc/cpuinfo says xend didn''t enforce dom0_cpus (2 != 1)
> FAIL: 01_enforce_dom0_cpus_basic_pos.test
> REASON: xm migrate returned invalid 256 != 0
> FAIL: 01_migrate_localhost_pos.test
> 
> I think none of these errors is related to the xm changes regarding 
> network-list or block-list.
> I expect the consequences of the xm changes NOT to influence the test 
> results on x86_64 or VMX - other challenges might be lurking there.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Feb 17, 2006 at 02:23:20PM -0800, Nivedita Singhvi wrote:
> Ewan, are you still running xm-test as part of your pre-commit
> regression testing?
Yes, we run the xm-test quick run before the change gets pushed from our
staging tree to xen-unstable, and the xm-test full run overnight (on
many machines).
> Also, have you started running on hvm hw?
James has been working on that recently.  It looks from the XenRT matrix
that it''s not there yet, but it certainly will be soon.
> We''d like to see more of these bugs caught prior to commit,
> and hoping to encourage all the developers out there to
> please run as well...
That''s what the staging tree is for -- if there was any breakage (which
it turns out that there wasn''t) then the change would never have been
pushed to the public unstable tree.  My email was a plea for someone to
improve the comprehensiveness of xm-test, now that we have a new
feature.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ewan Mellor wrote:
> That''s what the staging tree is for -- if there was any breakage
(which
> it turns out that there wasn''t) then the change would never have
been
> pushed to the public unstable tree.  My email was a plea for someone to
> improve the comprehensiveness of xm-test, now that we have a new
> feature.
Yep, not sure if there is a page on the Wiki for xm-test work
to be done, tests wanted, but would be handy..

We''re taking a look at cleaning up network tests, hoping to get to
enhancing hvm support, but have not yet got to anything
else..

thanks,
Nivedita

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefan

Thanks Stephan.

On Fri, 2006-02-17 at 17:03 -0500, Stefan Berger wrote:
> 
> xen-devel-bounces@lists.xensource.com wrote on 02/17/2006 02:54:21 PM:
> 
> > Stefan
> > Hi
> > Thanks for the xm-text initiative.
> > 
> > Did you test with xm-test (the whole suite of testx) on i386 and/or
> > x86_64 and/or VMX, before submitting the patches? Did they all work?
> >  
> 
> 
> Here''s now the output of a testrun on x86: 
> 
> REASON: (7 nics) Console didn''t respond: probably crashed!
> FAIL: 13_create_multinic_pos.test
> REASON: ping loopback failed for size 65507. ping eth0 failed for size
> 65507.
> XFAIL: 02_network_local_ping_pos.test
> REASON: Ping to dom0 failed for size 32767 65507.
> XFAIL: 05_network_dom0_ping_pos.test
> REASON: Ping failed for size 32767 65507.
> XFAIL: 11_network_domU_ping_pos.test
> REASON: /proc/cpuinfo says xend didn''t enforce dom0_cpus (2 != 1)
> FAIL: 01_enforce_dom0_cpus_basic_pos.test
> REASON: xm migrate returned invalid 256 != 0
> FAIL: 01_migrate_localhost_pos.test
> 
> I think none of these errors is related to the xm changes regarding
> network-list or block-list. 
> I expect the consequences of the xm changes NOT to influence the test
> results on x86_64 or VMX - other challenges might be lurking there. 
> 
>    Stefan
> 
> > Dan is right, the doc also needs work. 
> 
> 
> > 
> > woody
> > =============> > On Fri, 2006-02-17 at 11:00 -0800, Daniel
Stekloff wrote:
> > > On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > > > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger
wrote:
> > > > 
> > > > > This patch displays the
network-list/block-list/vtpm-list
> using the ''xm''
> > > > > command. It supports the ''--long''
option.
> > > > > 
> > > > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > > > 
> > > > Applied, thank you.
> > > > 
> > > > This will break xm-test.  Does anyone fancy fixing it up? 
The
> > > > least-effort thing to do is change all of the calls to
> block-list and
> > > > network-list to become block-list --long and network-list
> --long, but
> > > > it would be better if we fixed the eyecatchers (where
necessary)
> to work
> > > > with the new, formatted commands, and maybe added a few
tests
> for
> > > > xyz-list --long as well.
> > > > 
> > > > And of course it would be nice to have tests for vtpm-list 
> > (after detecting
> > > > the presence of appropriate hardware, I guess).
> > > > 
> > > > Any volunteers?
> > > 
> > > 
> > > Hi,
> > > 
> > > Three comments:
> > > 
> > > 1) Changes like those introduced by this patch should be
submitted
> with
> > > corresponding tests in xm-test. We want to continue to use
xm-test
> to
> > > verify functionality.
> > > 
> > > 2) The documentation - like man pages - should be updated along
> with the
> > > new functionality. 
> > > 
> > > 3) xm-test should be used to verify patches prior to submitting
> and
> > > applying. 
> > > 
> > > Thanks,
> > > 
> > > Dan
> > > 
> > > 
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@lists.xensource.com
> > > http://lists.xensource.com/xen-devel
> > > 
> > -- 
> > Sincerely,      Woody Marvel
> > IBM Linux Technology Center
> > Open Source Virtualization
> > email: marvel@us.ibm.com
> > 503-578-3833   Beaverton, OR 97006
> > **********************************
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
-- 
Sincerely,      Woody Marvel
IBM Linux Technology Center
Open Source Virtualization
email: marvel@us.ibm.com
503-578-3833   Beaverton, OR 97006
**********************************


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel