marsijanin
2010-Nov-03 10:01 UTC
[ogg-dev] Subject: [PATCH] fix comments header for PCM content
Hi! I found what liboggz can't read comments for logical bitstreams with OggPCM content, because of in oggz_auto_read_comments () function from oggz_auto.c case entry for OGGZ_CONTENT_PCM is missing. Steps to represent: 1. Generate simple ogg file with content of type OGGZ_CONTENT_PCM and some comments in comments (second) header. 2. Try to read comments via oggz-comments tool. Attachments: 1. Simple ogg file with content of type OggPCM. 2. Couple of C code what generate 1. 3. Patch, what fix described problem. wbr, Nikolay V. Razbegaev. -------------- next part -------------- A non-text attachment was scrubbed... Name: test.ogg Type: audio/ogg Size: 414 bytes Desc: not available Url : http://lists.xiph.org/pipermail/ogg-dev/attachments/20101103/74790646/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: make-test-ogg-pcm.c Type: text/x-csrc Size: 1901 bytes Desc: not available Url : http://lists.xiph.org/pipermail/ogg-dev/attachments/20101103/74790646/attachment.c -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-fix-comments-header-offset-calculation-for-PCM-conte.patch Type: text/x-diff Size: 805 bytes Desc: not available Url : http://lists.xiph.org/pipermail/ogg-dev/attachments/20101103/74790646/attachment.patch
Conrad Parker
2010-Nov-04 11:50 UTC
[ogg-dev] Subject: [PATCH] fix comments header for PCM content
On 3 November 2010 19:01, marsijanin <marsijanin at gmail.com> wrote:> Hi! > > I found what liboggz can't read comments for logical bitstreams with > OggPCM content, because of in oggz_auto_read_comments () function from > oggz_auto.c case entry for OGGZ_CONTENT_PCM is missing. > > Steps to represent: > > 1. Generate simple ogg file with content of type OGGZ_CONTENT_PCM and > some comments in comments (second) header. > > 2. Try to read comments via oggz-comments tool. > > Attachments: > > 1. Simple ogg file with content of type OggPCM. > > 2. Couple of C code what generate 1. > > 3. Patch, what fix described problem.Hi, good job! applied to liboggz git. cheers, Conrad.