flac dev - Mar 2012 - PATCH: Add test for metaflac --add-replay-gain

Erik


? ? Testing FLAC file with unknown metadata... OK
? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then'
? ? ./test_metaflac.sh: line 450: `? then'


Do both /bin/bash and /bin/dash give exactly the same error message ?

Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Sunday, March 11, 2012 3:16:11 AM
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
 
Earl Chew wrote:
> There is only one test to verify handling of harmonics of the filter table
> sampling frequencies.
Earl,

I've had a couple of attempts to get this patch working, without luck.

With this patch applied, when i run the test_metaflac.sh script, I get:

? ? Testing FLAC file with unknown metadata... OK
? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then'
? ? ./test_metaflac.sh: line 450: `? then'

It's basically barfing at this line:

? if [ -n "${ACTION##*:*}" ] ; then

Not sure where to go with this. You offerred Perl which I rejected mainly
because I read Perl :-). Are you comfortable with Python?

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120313/9187c90e/attachment.htm

Earl Chew wrote:
> Erik
> 
> 
> ? ? Testing FLAC file with unknown metadata... OK
> ? ? ./test_metaflac.sh: line 450: syntax error near unexpected token
`then'
> ? ? ./test_metaflac.sh: line 450: `? then'
Thats the error with bash. With dash its:

      ./test_metaflac.sh: 449: ./test_metaflac.sh: Syntax error:
"then" unexpected (expecting "done")

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik,

I cannot reproduce the problem you see with either dash(1) or bash(1).
> test case62: --import-picture-from... OK
> Testing FLAC file with unknown metadata... OK
> Testing FLAC replaygain 8000 (8000 x 1) ... OK
> Testing FLAC replaygain 11025 (11025 x 1) ... OK
> Testing FLAC replaygain 11025 (11025 x 1) ... OK
> Testing FLAC replaygain 12000 (12000 x 1) ... OK
> Testing FLAC replaygain 16000 (16000 x 1) ... OK
> Testing FLAC replaygain 18900 (18900 x 1) ... OK
> Testing FLAC replaygain 22050 (22050 x 1) ... OK
> Testing FLAC replaygain 24000 (24000 x 1) ... OK
> Testing FLAC replaygain 28000 (28000 x 1) ... OK
> Testing FLAC replaygain 32000 (32000 x 1) ... OK
> Testing FLAC replaygain 36000 (36000 x 1) ... OK
> Testing FLAC replaygain 37800 (37800 x 1) ... OK
> Testing FLAC replaygain 44100 (44100 x 1) ... OK
> Testing FLAC replaygain 48000 (48000 x 1) ... OK
> Testing FLAC replaygain 96000 (48000 x 2) ... OK
> Testing FLAC replaygain 192000 (48000 x 4) ... OK

Would you please place the copy of both the unpatched and patched version of the
test_metaflac.sh with the problem in a *tar.gz or *zip file, and send it to me
directly ?


I am using:

dash.i686??????????? 0.5.5.1-3.fc12
bash.i686??????????? 4.0.33-1.fc12


Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Tuesday, March 13, 2012 12:43:11 PM
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
 
Earl Chew wrote:
> Erik
> 
> 
> ? ? Testing FLAC file with unknown metadata... OK
> ? ? ./test_metaflac.sh: line 450: syntax error near unexpected token
`then'
> ? ? ./test_metaflac.sh: line 450: `? then'
Thats the error with bash. With dash its:

? ? ? ./test_metaflac.sh: 449: ./test_metaflac.sh: Syntax error:
"then" unexpected (expecting "done")

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120318/a7579603/attachment.htm