Erik, I cannot reproduce the problem you see with either dash(1) or bash(1).> test case62: --import-picture-from... OK > Testing FLAC file with unknown metadata... OK > Testing FLAC replaygain 8000 (8000 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 12000 (12000 x 1) ... OK > Testing FLAC replaygain 16000 (16000 x 1) ... OK > Testing FLAC replaygain 18900 (18900 x 1) ... OK > Testing FLAC replaygain 22050 (22050 x 1) ... OK > Testing FLAC replaygain 24000 (24000 x 1) ... OK > Testing FLAC replaygain 28000 (28000 x 1) ... OK > Testing FLAC replaygain 32000 (32000 x 1) ... OK > Testing FLAC replaygain 36000 (36000 x 1) ... OK > Testing FLAC replaygain 37800 (37800 x 1) ... OK > Testing FLAC replaygain 44100 (44100 x 1) ... OK > Testing FLAC replaygain 48000 (48000 x 1) ... OK > Testing FLAC replaygain 96000 (48000 x 2) ... OK > Testing FLAC replaygain 192000 (48000 x 4) ... OKWould you please place the copy of both the unpatched and patched version of the test_metaflac.sh with the problem in a *tar.gz or *zip file, and send it to me directly ? I am using: dash.i686??????????? 0.5.5.1-3.fc12 bash.i686??????????? 4.0.33-1.fc12 Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Tuesday, March 13, 2012 12:43:11 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote:> Erik > > > ? ? Testing FLAC file with unknown metadata... OK > ? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then' > ? ? ./test_metaflac.sh: line 450: `? then'Thats the error with bash. With dash its: ? ? ? ./test_metaflac.sh: 449: ./test_metaflac.sh: Syntax error: "then" unexpected (expecting "done") Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120318/a7579603/attachment.htm
Erik de Castro Lopo
2012-Mar-18 20:36 UTC
[flac-dev] PATCH: Add test for metaflac --add-replay-gain
Earl Chew wrote:> I cannot reproduce the problem you see with either dash(1) or bash(1).Just found something really werid. I opened the patch in a text editor that doesn't support unicode and found this: +????????awk -- ' +????????BEGIN { +?????????????????????? samplerate = '$1'; Everywhere there was supposed to be a space (hex 0a) there was a pair (hex c2 0a). In my regular unicode aware editor, the hex c2 0a pair just showed up as a space. I just checked and your original patch also has these extra bytes. This may be something added by YahooMail. With the cruft removed, the patch applied and the tests ran correctly. I'll commit and push after a little testing. Thanks. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik, Thanks for the update. It certainly was a strange problem to debug. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Sunday, March 18, 2012 1:36:42 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote:> I cannot reproduce the problem you see with either dash(1) or bash(1).Just found something really werid. I opened the patch in a text editor that doesn't support unicode and found this: ? ? +????????awk -- ' ? ? +????????BEGIN { ? ? +?????????????????????? samplerate = '$1'; Everywhere there was supposed to be a space (hex 0a) there was a pair (hex c2 0a). In my regular unicode aware editor, the hex c2 0a pair just showed up as a space. I just checked and your original patch also has these extra bytes. This may be something added by YahooMail. With the cruft removed, the patch applied and the tests ran correctly. I'll commit and push after a little testing. Thanks. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120318/e3bc77bc/attachment.htm