Earl Chew wrote:> One per filter table entry. That's 12 files right now.Thats probably a bit much.> The files could be generated on the fly, but that would either require > another program or script (eg Perl),Anything but Perl. I can write Perl but I can't read it :-).> or a dependence on an external toolkit such as sox.I'd be ok with requiring sox to run the test suite.> The tests increase the runtime of test_metaflac.sh from 11s to 15s > on my machine.Thats fine too. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Ok. I'll redo the test using sox. Earl ----- Original Message ----- From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Tuesday, February 14, 2012 12:13:39 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote:> One per filter table entry. That's 12 files right now.Thats probably a bit much.> The files could be generated on the fly, but that would either require > another program or script (eg Perl),Anything but Perl. I can write Perl but I can't read it :-).> or a dependence on an external toolkit such as sox.I'd be ok with requiring sox to run the test suite.> The tests increase the runtime of test_metaflac.sh from 11s to 15s > on my machine.Thats fine too. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
What about using the C library sin() and cos() functions to generate the test audio instead of sox? I did not see a description of how the test files are generated, so maybe this is easy or maybe it is hard. The benefit of shipping the test audio generation source code around with the FLAC sources is that the tests won't break when sox is modified. Brian Willoughby Sound Consulting On Feb 14, 2012, at 12:13, Erik de Castro Lopo wrote:> > Earl Chew wrote: > >> One per filter table entry. That's 12 files right now. > > Thats probably a bit much. > >> The files could be generated on the fly, but that would either >> require >> another program or script (eg Perl), > > Anything but Perl. I can write Perl but I can't read it :-). > >> or a dependence on an external toolkit such as sox. > > I'd be ok with requiring sox to run the test suite. > >> The tests increase the runtime of test_metaflac.sh from 11s to 15s >> on my machine. > > Thats fine too. > > Erik
Brian Willoughby wrote:> What about using the C library sin() and cos() functions to generate > the test audio instead of sox? I did not see a description of how > the test files are generated, so maybe this is easy or maybe it is > hard. The benefit of shipping the test audio generation source code > around with the FLAC sources is that the tests won't break when sox > is modified.+1 Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/