flac dev - Feb 2012 - Regain play analysis patches

Earl Chew wrote:
> Erik,
> 
> Ok. I've updated the patches, and made some additions to the test
harness.
> 
> For the test harness, I used sox to generate 1kHz wav files over a range of
> sampling rates. The test harness runs the replaygain analysis, and compares
> the resulting metadata.
> 
> Are you ok with this approach ?? It means that the wav files need to be
> checked into the repository.
How many? One or two would be fine.

The thing I'd really like to avoid is that test suite run time getting
any longer.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik,

One per filter table entry. That's 12 files right now.

The files could be generated on the fly, but that would either require another
program or script (eg Perl), or a dependence on an external toolkit such as sox.


The tests increase the runtime of test_metaflac.sh from 11s to 15s on my
machine.


What are your thoughts ?

Earl


----- Original Message -----
From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org
Cc: 
Sent: Tuesday, February 14, 2012 12:41:51 AM
Subject: Re: [flac-dev] Regain play analysis patches

Earl Chew wrote:
> Erik,
> 
> Ok. I've updated the patches, and made some additions to the test
harness.
> 
> For the test harness, I used sox to generate 1kHz wav files over a range of
> sampling rates. The test harness runs the replaygain analysis, and compares
> the resulting metadata.
> 
> Are you ok with this approach ?? It means that the wav files need to be
> checked into the repository.
How many? One or two would be fine.

The thing I'd really like to avoid is that test suite run time getting
any longer.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
_______________________________________________
flac-dev mailing list
flac-dev at xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Earl Chew wrote:
> One per filter table entry. That's 12 files right now.
Thats probably a bit much.
> The files could be generated on the fly, but that would either require
> another program or script (eg Perl),
Anything but Perl. I can write Perl but I can't read it :-).
> or a dependence on an external toolkit such as sox.
I'd be ok with requiring sox to run the test suite.
> The tests increase the runtime of test_metaflac.sh from 11s to 15s
> on my machine.
Thats fine too.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/