Earl Chew wrote:> That being said, I think my patch leaves us better off than before !I agree. We will add it as it is and then tweak futher as needed. Earl, would you be able to update your patch so that it applies against the current git master? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik, I'll rework the patches and send them out again. Earl ----- Original Message ----- From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Saturday, February 11, 2012 12:51:22 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote:> That being said, I think my patch leaves us better off than before !I agree. We will add it as it is and then tweak futher as needed. Earl, would you be able to update your patch so that it applies against the current git master? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik, Ok. I've updated the patches, and made some additions to the test harness. For the test harness, I used sox to generate 1kHz wav files over a range of sampling rates. The test harness runs the replaygain analysis, and compares the resulting metadata. Are you ok with this approach ?? It means that the wav files need to be checked into the repository. (There are already some small image files in the repository as a precedent.) Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Saturday, February 11, 2012 12:51:22 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote:> That being said, I think my patch leaves us better off than before !I agree. We will add it as it is and then tweak futher as needed. Earl, would you be able to update your patch so that it applies against the current git master? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Earl Chew wrote:> Erik, > > Ok. I've updated the patches, and made some additions to the test harness. > > For the test harness, I used sox to generate 1kHz wav files over a range of > sampling rates. The test harness runs the replaygain analysis, and compares > the resulting metadata. > > Are you ok with this approach ?? It means that the wav files need to be > checked into the repository.How many? One or two would be fine. The thing I'd really like to avoid is that test suite run time getting any longer. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/