Speex dev - Nov 2010 - Patch: ARM: fix inline assembly when compiling for Thumb-2

Hi there.  The attached patch adds If-Then (IT) instructions to the
ARM inline assembly in Speex, allowing it to compile in Thumb-2 mode.
Traditional 32 bit ARM instructions can be conditionally executed
depending on which flags are currently set.  Thumb-2 requires an 'IT'
instruction instead that affects up to the next four instructions.
Note that when compiling for ARM 32, IT instructions are validated
then dropped, so this patch should have no effect on ARM 32 builds.

Tested on Ubuntu Maverick with the Linaro GCC 4.5-2010.11-1 compiler
with --enable-arm4-asm and --enable-arm5e-asm.  Compiles fine, and a
small file run through speexdec seems fine.  Is there a test suite
that I could run?

-- Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: speex-explicit-it.patch
Type: text/x-diff
Size: 6278 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/speex-dev/attachments/20101125/dec91d80/attachment.patch

On Thu, Nov 25, 2010 at 1:27 PM, Michael Hope <michael.hope at linaro.org>
wrote:
> Hi there. ?The attached patch adds If-Then (IT) instructions to the
> ARM inline assembly in Speex, allowing it to compile in Thumb-2 mode.
> Traditional 32 bit ARM instructions can be conditionally executed
> depending on which flags are currently set. ?Thumb-2 requires an
'IT'
> instruction instead that affects up to the next four instructions.
> Note that when compiling for ARM 32, IT instructions are validated
> then dropped, so this patch should have no effect on ARM 32 builds.
>
> Tested on Ubuntu Maverick with the Linaro GCC 4.5-2010.11-1 compiler
> with --enable-arm4-asm and --enable-arm5e-asm. ?Compiles fine, and a
> small file run through speexdec seems fine. ?Is there a test suite
> that I could run?
Hi there.  Any thoughts on this patch?

-- Michael