search for: inlin

RFC: Inlining Report Motivation Making good inlining choices while optimizing an application is often key to achieving optimal performance. While the compiler's default inlining heuristics sometimes provide great out-of-box results, optimal performance is sometimes achieved only after varying the setti...

Hi, I browsed the LLVM inliner implementation, and it seems there is room for improvement. (I have not read it too carefully, so correct me if what I observed is wrong). First the good side of the inliner -- the function level summary and inline cost estimation is more elaborate and complete than gcc. For instance, it consid...

On Nov 23, 2010, at 5:07 PM, Xinliang David Li wrote: > Hi, I browsed the LLVM inliner implementation, and it seems there is room for improvement. (I have not read it too carefully, so correct me if what I observed is wrong). > > First the good side of the inliner -- the function level summary and inline cost estimation is more elaborate and complete than gcc. For instance,...

On Aug 26, 2009, at 12:01 PM, Devang Patel wrote: >>> I do not understand how the "inlinehint" will help. How will it >>> influence the inliner ? >> >> The hint should make it more attractive to inline. I don't know >> the details >> yet and they will require some experimenting. >> > > In that case you want to add hint to A also...

Xinliang David Li wrote: > Hi, I browsed the LLVM inliner implementation, and it seems there is > room for improvement. (I have not read it too carefully, so correct me > if what I observed is wrong). > > First the good side of the inliner -- the function level summary and > inline cost estimation is more elaborate and complete than gcc....

...quot;Hal Finkel" <hfinkel at anl.gov> > Cc: "cfe commits" <cfe-commits at cs.uiuc.edu>, "List" <llvmdev at cs.uiuc.edu>, "Xinliang David Li" <davidxl at google.com> > Sent: Thursday, July 9, 2015 8:08:38 PM > Subject: Re: [LLVMdev] Inline hint for methods defined in-class > > On Thu, Jul 9, 2015 at 4:30 PM, Hal Finkel < hfinkel at anl.gov > wrote: > > > ----- Original Message ----- > > From: "Richard Smith" < richard at metafoo.co.uk > > > To: "Xinliang David Li" < da...

On Tue, Nov 23, 2010 at 8:07 PM, Xinliang David Li <xinliangli at gmail.com> wrote: > Hi, I browsed the LLVM inliner implementation, and it seems there is room > for improvement.  (I have not read it too carefully, so correct me if what I > observed is wrong). > First the good side of the inliner -- the function level summary and inline > cost estimation is more elaborate and complete than gcc. For...

On Mar 15, 2006, at 11:15 AM, Chris Lattner wrote: > On Wed, 15 Mar 2006, Vikram S. Adve wrote: >>> Why can't the compiler pass just call InlineFunction(CallSite) on >>> the callsite it wants inlined? The only way that can fail is if >>> LLVM cannot ever inline the call (e.g. it uses varargs). > >> In some cases, that would be fine. But in other cases: >> (1) It cannot "un-inline" any functi...

On Aug 26, 2009, at 2:31 PM, David Vandevoorde wrote: > > >> I know/hope that the proposal isn't for the inlinehint to be a >> synonym >> for "force inline", it would just raise the threshold to increase the >> likeliness that it would be inlined. The question is whether >> "something being c++ inline" in any way is really trustworthy, and if >> so, wheth...

On Thu, Aug 27, 2009 at 6:00 PM, David Greene<dag at cray.com> wrote: > On Wednesday 26 August 2009 12:59, Dale Johannesen wrote: > >> class X { >> int A(int x) {....} >> inline int B(int x); >> }; >> inline int X::B(int x) {...} >> >> Per the language standard, A and B are semantically identical, both >> "inline". It's been suggested that we should omit the inlinehint on >> A, on the grounds that many C++ programmers do...

...s) > hex dump (first 32 bytes): > 01 00 00 00 81 88 ff ff 00 00 00 00 82 88 ff ff ................ > d0 6a bc 1c 81 88 ff ff d0 6a bc 1c 81 88 ff ff .j.......j...... > backtrace: > [<000000006c752978>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline] > [<000000006c752978>] slab_post_alloc_hook mm/slab.h:439 [inline] > [<000000006c752978>] slab_alloc mm/slab.c:3326 [inline] > [<000000006c752978>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 > [<00000000b3825d52>] kmalloc include/linu...

...s) > hex dump (first 32 bytes): > 01 00 00 00 81 88 ff ff 00 00 00 00 82 88 ff ff ................ > d0 6a bc 1c 81 88 ff ff d0 6a bc 1c 81 88 ff ff .j.......j...... > backtrace: > [<000000006c752978>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline] > [<000000006c752978>] slab_post_alloc_hook mm/slab.h:439 [inline] > [<000000006c752978>] slab_alloc mm/slab.c:3326 [inline] > [<000000006c752978>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 > [<00000000b3825d52>] kmalloc include/linu...

...ichard at metafoo.co.uk> > > Cc: "Xinliang David Li" <davidxl at google.com>, "cfe commits" < > cfe-commits at cs.uiuc.edu>, "List" <llvmdev at cs.uiuc.edu> > > Sent: Thursday, July 9, 2015 8:46:22 PM > > Subject: Re: [LLVMdev] Inline hint for methods defined in-class > > > > ----- Original Message ----- > > > From: "Richard Smith" <richard at metafoo.co.uk> > > > To: "Hal Finkel" <hfinkel at anl.gov> > > > Cc: "cfe commits" <cfe-commits at cs.u...

On Aug 26, 2009, at 7:02 PM, David Vandevoorde wrote: >> It's actually the other way around. llvm has always ignored the >> "inline" keyword and now we are finding out we are missing some >> important cases. > > Okay. It's the "other way around" in terms of history, but it looks > like the conclusion might be the same: Purely heuristics-based > inlining hasn't been proven entirely comp...

You may have noticed I added an "inlinehint" attribute to the IR yesterday, to represent user declarations that hint inlining would be a good idea ("inline" keyword). Chris and I have been discussing how to hook it up to the C++ FE. Consider: class X { int A(int x) {....} inline int B(int x); }; inline in...

Hi, I want to have some functions in my code inline so I use the *inline * keyword: *inline void foo() {}* On some functions the compiler inlines the function but it fails to do so on other functions and thus I get a linkage error: *error: undefined reference to 'foo'* What are the conditions that make the compiler refuse inline? Thank...

Vikram S. Adve wrote: Hmmm. It seems the discussion has grown a little bit larger than I had intended. :) Basically what I think would be useful is an option to the inliner that gives it a list of functions to skip when inlining. My argument for this is that we have several transformations now that search for calls to specific functions; if those functions are inlined, the transform pass can no longer find the calls. I would like the list of functions excluded...

On Sat, 7 May 2005, Markus F.X.J. Oberhumer wrote: > I see that you are objecting explicit inline control. > > The main problem is that inlining is absolutely crucial for some > "modern" programming styles. E.g. we use a huge collection of small C++ > template classes and template metaclasses, most of which have very > trivial and limited functionality (think of it...

...es 4294949245 (age 13.030s) hex dump (first 32 bytes): 01 00 00 00 20 69 6f 63 00 00 00 00 64 65 76 2f .... ioc....dev/ 50 fe 21 24 81 88 ff ff 50 fe 21 24 81 88 ff ff P.!$....P.!$.... backtrace: [<00000000ae0c4ae0>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000ae0c4ae0>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000ae0c4ae0>] slab_alloc mm/slab.c:3326 [inline] [<00000000ae0c4ae0>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<0000000079ebab38>] kmalloc include/linux/slab.h:547 [inline...

...es 4294949245 (age 13.030s) hex dump (first 32 bytes): 01 00 00 00 20 69 6f 63 00 00 00 00 64 65 76 2f .... ioc....dev/ 50 fe 21 24 81 88 ff ff 50 fe 21 24 81 88 ff ff P.!$....P.!$.... backtrace: [<00000000ae0c4ae0>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000ae0c4ae0>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000ae0c4ae0>] slab_alloc mm/slab.c:3326 [inline] [<00000000ae0c4ae0>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<0000000079ebab38>] kmalloc include/linux/slab.h:547 [inline...