rsync - Mar 2020 - Would you expect --perms -M--fake-super to set the file mode to the original one?

rsync --perms -M--fake-super src dst

For me, this command means that rsync should save the original perms in the
xattr, and leave the real file mode to the umask default. Currently it also
modifies the real file mode, and there is no way to store something 
different
in the xattr.

According to an old bug report that I found, more people would like 
--fake-super to be a complete attribute emulation layer.

https://bugzilla.samba.org/show_bug.cgi?id=7112

Do you agree? I'm in the process of implementing this as a bug fix to 
rsync,
and would like to know if everybody agrees with this behaviour. The patch
would also modify the man page to document it under --perms.


Regards,
Dimitris

Permissions don't require super.  Any place where permissions can't be
stored certainly can't handle xattrs either.  So, I wouldn't expect
--fake-super to affect --perms at all.

On 3/12/20 12:46 PM, Dimitrios Apostolou via rsync
wrote:
> rsync --perms -M--fake-super src dst
> 
> For me, this command means that rsync should save the original perms in the
> xattr, and leave the real file mode to the umask default. Currently it also
> modifies the real file mode, and there is no way to store something
> different
> in the xattr.
> 
> According to an old bug report that I found, more people would like
> --fake-super to be a complete attribute emulation layer.
> 
> https://bugzilla.samba.org/show_bug.cgi?id=7112
> 
> Do you agree? I'm in the process of implementing this as a bug fix to
> rsync,
> and would like to know if everybody agrees with this behaviour. The patch
> would also modify the man page to document it under --perms.
> 
> 
> Regards,
> Dimitris
> 
> 
-- 
~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,
	Kevin Korb			Phone:    (407) 252-6853
	Systems Administrator		Internet:
	FutureQuest, Inc.		Kevin at FutureQuest.net  (work)
	Orlando, Florida		kmk at sanitarium.net (personal)
	Web page:			https://sanitarium.net/
	PGP public key available on web site.
~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.samba.org/pipermail/rsync/attachments/20200312/d7a62f32/signature.sig>

Thank you for the feedback, I'm glad to see that different people see the 
issue
differently. As a followup question, what would you expect this to do:

rsync --perms --chmod g+rX -M--fake-super src dst

I would expect it to store the original permissions in the xattr, while
modifying the real file mode according to the chmod.

On Thursday, March 12, 2020 6:06:34 PM CET, Kevin Korb via rsync
wrote:
> Permissions don't require super.  Any place where permissions can't
be
> stored certainly can't handle xattrs either.  So, I wouldn't expect
> --fake-super to affect --perms at all.
>
> On 3/12/20 12:46 PM, Dimitrios Apostolou via rsync wrote:
>> rsync --perms -M--fake-super src dst
>> 
>> For me, this command means that rsync should save the original 
>> perms in the
>> xattr, and leave the real file mode to the umask default. 
>> Currently it also
>> modifies the real file mode, and there is no way to store something
>> different ...
>