rsync - Oct 2019 - [Bug 14163] New: RSYNC_SSL_PORT env should be set for invocation of --rsh command

https://bugzilla.samba.org/show_bug.cgi?id=14163

            Bug ID: 14163
           Summary: RSYNC_SSL_PORT env should be set for invocation of
                    --rsh command
           Product: rsync
           Version: 3.1.3
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayne at opencoder.net
          Reporter: bjacke at samba.org
        QA Contact: rsync-qa at samba.org

when running the rsync with -e/--rsh stunnel-rsync and an alternative port on
the command line (--port 12345), when this port should be communicated to the
"rsh" program to be evaluated, which could be simply done by setting
the
RSYNC_SSL_PORT environment variable in case the --port option was used with
rsync.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=14163

Wayne Davison <wayne at opencoder.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Wayne Davison <wayne at opencoder.net> ---
I've committed code that sets an RSYNC_PORT value in the environment for any
daemon-over-rsh connections. The value will be "0" if the default port
is being
assumed, or the specified port number. This lets a script choose their own
default port while still being able to discern if the user manually requested
port 873.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=14163

Bj?rn Jacke <bjacke at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Bj?rn Jacke <bjacke at samba.org> ---
thanks but the default port handling does not work correctly yet. Calling rsync
like:

rsync --rsh=openssl-rsync -aiv HOST::module

without any port definition, rsync sets the env var RSYNC_PORT=873 for the
script. This is not what is desired here. Without an explicit port definition
rsync should not be set to 873. Setting it to 0 as you mentioned in your
commend would be fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=14163

Wayne Davison <wayne at opencoder.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Wayne Davison <wayne at opencoder.net> ---
Fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.