Libguestfs - Mar 2017 - [PATCH] lib: direct: Don't ever use -no-kvm-pit-reinjection.

On qemu 1.1.2:

  qemu-system-x86_64: -no-kvm-pit-reinjection: invalid option

Thanks: josv @ IRC
---
 lib/launch-direct.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/launch-direct.c b/lib/launch-direct.c
index efedf92..db9b9f3 100644
--- a/lib/launch-direct.c
+++ b/lib/launch-direct.c
@@ -414,10 +414,7 @@ launch_direct (guestfs_h *g, void *datav, const char *arg)
   if (guestfs_int_qemu_supports (g, data->qemu_data, "-no-hpet"))
{
     ADD_CMDLINE ("-no-hpet");
   }
-  if (!guestfs_int_version_ge (&data->qemu_version, 1, 3, 0))
-    ADD_CMDLINE ("-no-kvm-pit-reinjection");
-  else {
-    /* New non-deprecated way, added in qemu >= 1.3. */
+  if (guestfs_int_version_ge (&data->qemu_version, 1, 3, 0)) {
     ADD_CMDLINE ("-global");
     ADD_CMDLINE ("kvm-pit.lost_tick_policy=discard");
   }
-- 
2.10.2

On Thursday, 16 March 2017 10:59:23 CET Richard W.M. Jones
wrote:
> On qemu 1.1.2:
> 
>   qemu-system-x86_64: -no-kvm-pit-reinjection: invalid option
> 
> Thanks: josv @ IRC
Thanks to: John Sucaet.

LGTM otherwise.

Thanks,
-- 
Pino Toscano