similar to: [PATCH] lib: direct: Don't ever use -no-kvm-pit-reinjection.

--- src/launch-direct.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/launch-direct.c b/src/launch-direct.c index 6eaee63..c091732 100644 --- a/src/launch-direct.c +++ b/src/launch-direct.c @@ -491,7 +491,14 @@ launch_direct (guestfs_h *g, void *datav, const char *arg) */ ADD_CMDLINE ("-no-hpet"); #endif - ADD_CMDLINE

virtio-scsi has been supported in qemu since 2012, and it is superior in every respect to virtio-blk. There's no reason to still be using virtio-blk. virtio-scsi support was initially added in 2012 (commit 0c0a7d0d868d153adf0600189f771459e1068b0a). You can still use virtio-blk using the (deprecated) iface parameter, but don't do that in new code. --- lib/guestfs-internal.h | 1 -

This QEMU property is specific to x86/x86_64, so add it only on these architectures. --- lib/launch-direct.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/launch-direct.c b/lib/launch-direct.c index bc43dcea2..3b848165c 100644 --- a/lib/launch-direct.c +++ b/lib/launch-direct.c @@ -519,8 +519,10 @@ launch_direct (guestfs_h *g, void *datav, const char *arg) arg ("-rtc",

>From josv on IRC: > Hi! I am on Fedora 25 and installed libguestfs (1.36.2) from the > fedora repo. It seems that the squashfs feature is missing in this > installation (guestfish add-drive /dev/null : run : available squashfs > returns "error: squashfs: group not available"). What would be the > recommended way to have the squashfs feature available? $ guestfish -a

Introduce a new struct version with few helper functions for it: this allows to "atomically" represent a version number, without different variables to be used and checked together. Add a initialization function from a libvirt-style version number, and apply it for the qemu and libvirt versions in the direct and libvirt backends. --- src/Makefile.am | 1 +

See: https://bugzilla.redhat.com/show_bug.cgi?id=1614948#c23 Thanks: David Gibson. --- lib/launch-direct.c | 4 ++++ lib/launch-libvirt.c | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/lib/launch-direct.c b/lib/launch-direct.c index 47e8f37de..e99c33347 100644 --- a/lib/launch-direct.c +++ b/lib/launch-direct.c @@ -523,6 +523,10 @@ launch_direct (guestfs_h *g, void *datav,

On Tuesday, 5 September 2017 16:55:08 CEST Richard W.M. Jones wrote: > Since qemu 2.10, qemu locks all drives even when they are opened > readonly. This disables this locking in this safe case. > > Incomplete fix for > https://bugzilla.redhat.com/show_bug.cgi?id=1417306 > --- I guess that, according to the other message in this thread, the commit message will be amended to use

Since qemu 2.10, qemu locks all drives even when they are opened readonly. This disables this locking in this safe case. Incomplete fix for https://bugzilla.redhat.com/show_bug.cgi?id=1417306 --- lib/launch-direct.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/launch-direct.c b/lib/launch-direct.c index 3b848165c..e5465539d 100644 --- a/lib/launch-direct.c +++

On Wed, Sep 06, 2017 at 10:41:24AM +0300, Roman Kagan wrote: > On Tue, Sep 05, 2017 at 03:55:08PM +0100, Richard W.M. Jones wrote: > > Since qemu 2.10, qemu locks all drives even when they are opened > > readonly. This disables this locking in this safe case. > > > > Incomplete fix for > > https://bugzilla.redhat.com/show_bug.cgi?id=1417306 > > --- >

Use the version struct in inspect_fs to hold the version of a filesystem, adapting the inspection code to that. Also, move the parts of the version parsing to helper functions of the version struct, so common bits like parsing "X.Y" or "X" version strings is done only once. --- v2 changes: - adapt to v2 changes in patch #1 src/guestfs-internal.h | 8 +-

On Wednesday, 19 April 2017 12:00:17 CEST Richard W.M. Jones wrote: > virtio-scsi has been supported in qemu since 2012, and it is superior > in every respect to virtio-blk. There's no reason to still be using > virtio-blk. > > virtio-scsi support was initially added in 2012 > (commit 0c0a7d0d868d153adf0600189f771459e1068b0a). > > You can still use virtio-blk using

On Thursday, 6 April 2017 00:26:26 CEST Richard W.M. Jones wrote: > > >From josv on IRC: > > > Hi! I am on Fedora 25 and installed libguestfs (1.36.2) from the > > fedora repo. It seems that the squashfs feature is missing in this > > installation (guestfish add-drive /dev/null : run : available squashfs > > returns "error: squashfs: group not

From: "Richard W.M. Jones" <rjones@redhat.com> AAVMF is an open source UEFI implementation for aarch64 based on OVMF. As aarch64 is heading for requiring UEFI even inside guests, if the AAVMF firmware is installed on the host, use it as a hint that we should boot the guest using AAVMF instead of the default "empty machine". Note this requires very recent AAVMF, libvirt,

The latter is a better way to disable the qemu display output as we need to, without enabling extra devices (which are disabled already, anyway). Also, related to the change above, ban the -display parameter from the ones that can be supplied by the user. --- configure.ac | 8 ++++---- src/launch-direct.c | 12 ++++++++---- src/launch.c | 1 + 3 files changed, 13 insertions(+), 8

When using the direct backend, you should see the result of testing the qemu binary for the availability of KVM: libguestfs: qemu KVM: enabled Thanks: Andrea Bologna. --- lib/guestfs-internal.h | 1 + lib/launch-direct.c | 40 +++++------------- lib/qemu.c | 94 +++++++++++++++++++++++++++++++++++++++++- 3 files changed, 105 insertions(+), 30 deletions(-) diff --git

NB: This requires a qemu patch by Eduardo which is currently awaiting review: https://www.mail-archive.com/qemu-devel@nongnu.org/msg422959.html So not to be applied yet unless that qemu change goes upstream. Rich.

QEMU >= 2.10 started to do mandatory locking. This checks the QMP schema to see if we are using that version of qemu. (Note it is sometimes disabled in downstream builds, and it was also enabled in upstream prereleases with version 2.9.9x, so we cannot just check the version number). --- lib/guestfs-internal.h | 1 + lib/qemu.c | 60

Hi, this adds an helper version struct, and uses it in the backends (for the libvirt and qemu versions) and inspection code. This also moves common code to that, so it is not repeated in many places. This should help with the small refactoring proposed with https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html Thanks, Pino Toscano (2): src: start unifying version handling

?Hi, ?I've installed libvirt-0.9.13 on RHEL6.2 from the source code. I cannot make sVirt working with LXC. (sVirt works well with KVM, though.) I can start an LXC instance, but the label of the process is not right. Can someone help me? I tried to change /etc/libvirtd/lxc.conf file to explicitly enable security_driver = "selinux". But it ends up with error saying "error :

On 04/29/2017 04:38 AM, Stefano Ricci wrote: > 2017-04-28 14:33 GMT+02:00 Michal Privoznik <mprivozn@redhat.com>: >> On 04/27/2017 04:31 PM, Stefano Ricci wrote: >>> Here is the backtrace of the libvirt process just started >> >> [Just a side note, you shouldn't top post on technical lists. Gmail >> sucks at this.] >> >>> >>>