Nouveau - Jul 2015 - [Bug 91170] New: World of Zoo (in Wine) has rendering issues

https://bugs.freedesktop.org/show_bug.cgi?id=91170

            Bug ID: 91170
           Summary: World of Zoo (in Wine) has rendering issues
           Product: Mesa
           Version: git
          Hardware: Other
               URL: http://store.steampowered.com/app/43100/
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: gyebro69 at gmail.com
        QA Contact: nouveau at lists.freedesktop.org

When the game loads to the menu the screen is scrambled with flashing polygons.
This doesn't occur with the binary drivers (340.76) or when starting the
game
with the software renderer.Disabling shader optimization doesn't resolve the
problem.

Screenshot:
http://imgur.com/xro8Ixr

Trace file:
https://drive.google.com/open?id=0B-tTbLKBl-tOdTJxT1o0c2dZMmc
The problem is first visible in frame #152, when the second splash screen is
displayed.

Demo version is available on Steam (needs Wine to run):
http://store.steampowered.com/app/43100/

Fedora 22 32-bit
Mesa 10.6-branchpoint-773-g1de93f9
Kernel 4.0.6-300.fc22.i686+PAE
Xorg 1.17.2
libdrm-2.4.61-3.fc22.i686

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150701/5e3673b9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

--- Comment #1 from Béla Gyebrószki <gyebro69 at gmail.com> ---
Sorry, I missed to specify my video card:

VGA compatible controller: NVIDIA Corporation G92 [GeForce GTS 250] (rev a2)
(prog-if 00 [VGA controller])

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150701/f9f4307e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

--- Comment #2 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Reproduced on GT215. Does not happen on GF108.

Geometry seems off as soon as the first or second title screen... will have to
double-check old versions, hopefully it's a regression we can bisect.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150702/c2b3673e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

--- Comment #3 from Ilia Mirkin <imirkin at alum.mit.edu> ---
OK, so forcing the inline vertex path rather than the stick-bo-into-pushbuf
path seems to help. Will try to track down what's different. Probably
something
dumb around alignment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150702/c3e08fd1/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

--- Comment #4 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Created attachment 116899
  --> https://bugs.freedesktop.org/attachment.cgi?id=116899&action=edit
bs fix

Ugh, the buffer-update-is-in-progress issue strikes again! I fixed this ages
ago, but it's back. [The first hunk of this patch is unrelated, but it also
won't hurt.]

So now to figure out why it's not fencing properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150703/36f372b7/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

--- Comment #5 from Béla Gyebrószki <gyebro69 at gmail.com> ---
(In reply to Ilia Mirkin from comment #4)
> Created attachment 116899 [details] [review]
> bs fix
> 
> Ugh, the buffer-update-is-in-progress issue strikes again! I fixed this
ages
> ago, but it's back. [The first hunk of this patch is unrelated, but it
also
> won't hurt.]
> 
> So now to figure out why it's not fencing properly.
The patch fixes the problem here as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150703/c25cd3b0/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

--- Comment #6 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Created attachment 116925
  --> https://bugs.freedesktop.org/attachment.cgi?id=116925&action=edit
another bs fix

This is very worrying... emitting more fences seems to fix it. Another place
where it helped was in nouveau_transfer_write. The joke of it is that emitting
a fence doesn't even kick the pushbuf, just writes the commands.

But since I'm not actually changing *which* fences are attached, I really
don't
see how this changes anything. Waiting on fence instead of fence_wr doesn't
seem to affect it either.

What this game does is totally NUTS btw. It has a 512KB vertex buffer, and
every time it maps it is with GL_MAP_INVALIDATE_BUFFER_BIT and writes all 512KB
each time. Which is fine, just... inefficient (probably).

It also has a 128KB index buffer, of which it maps the whole range with 
GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_FLUSH_EXPLICIT_BIT. And then draws,
immediately maps it again, draws, etc. This is like the definition of how not
to use these buffers. Anyways, this forces the creation of a staging bo (in
GART), which receives a copy of the old 128KB of data, and returns a pointer to
that. Then the program updates the 12 or whatever bytes of data, and flushes
them, so *just* those 12 bytes get written. [I'm not kidding, it literally
updates 12 bytes a lot of the time.]

I tried adding kicks in copy_data & co, but that (expectedly) didn't
help.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150703/f0bfa2ae/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|World of Zoo (in Wine) has  |[NV50/Gallium] World of Zoo
                   |rendering issues            |(in Wine) has rendering
                   |                            |issues

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150712/98e923bf/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91170

GitLab Migration User <gitlab-migration at fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #7 from GitLab Migration User <gitlab-migration at
fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1075.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190918/4c877084/attachment.html>