openssh bugs - Apr 2015 - [Bug 2386] New: TERM env variable is always accepted by sshd, regardless the empty AcceptEnv setting

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

            Bug ID: 2386
           Summary: TERM env variable is always accepted by sshd,
                    regardless the empty AcceptEnv setting
           Product: Portable OpenSSH
           Version: 6.8p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Documentation
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jjelen at redhat.com

Created attachment 2597
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2597&action=edit
proposed patch

In our Red Hat bugzilla, we have such report, that this is not expected
behaviour.
For us it is obvious, that TERM variable is send and accepted
regardless configuration, because it is part of protocol. This doesn't
have to be obvious for some users so it should be mentioned in manual
pages. I propose such simple sentence (see attached patch).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2360

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Other                       |All
                 OS|Linux                       |All

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned-bugs at mindrot.org |dtucker at zip.com.au

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Committed a reworked patch.  Thanks, it will be in the 6.9 release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Jakub Jelen <jjelen at redhat.com> ---
I didn't check what you wrote there (unfortunately). Few remarks for
your upstream commits:
https://anongit.mindrot.org/openssh.git/commit/?id=85b96ef41374f3ddc9139581f87da09b2cd9199e
https://anongit.mindrot.org/openssh.git/commit/?id=43beea053db191cac47c2cd8d3dc1930158aff1a
https://anongit.mindrot.org/openssh.git/commit/?id=c1d5bcf1aaf1209af02f79e48ba1cbc76a87b56f

ssh_config is ok
sshd_config:
> environment variable is always sent whenever the client
> requests a pseudo-terminal is requested as it is required by the protocol.
 * variable is not sent, but accepted
 * "requests a pseudo-terminal is requested" doesn't make sense
   * [...] client requests a pseudo-terminal [...]
   * or
   * [...] a pseudo-terminal is requested [...]
   * but please not both

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
fixed, thanks

-requests a pseudo-terminal is requested as it is required by the
protocol.
+requests a pseudo-terminal as it is required by the protocol.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Stanislav Zidek <szidek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |szidek at redhat.com

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Christoph Anton Mitterer <calestyo at scientia.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |calestyo at scientia.net
         Resolution|FIXED                       |---

--- Comment #4 from Christoph Anton Mitterer <calestyo at scientia.net>
---
Reopening this, as the manpage in master still reads:
"environment variable is always sent whenever the client"
for the AcceptEnv directive, while it should read "... accpted ..." as
it has been pointed out by Jakub before.

Cheers,
Chris.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

--- Comment #5 from Christoph Anton Mitterer <calestyo at scientia.net>
---
Oh and one more:

I would at least hope (though I haven't checked) that TERM is only
accepted when sshd actually allows to create a PTY (can someone check
whether this is the case?).

Therefore it should read:
"whenever a pseudoterminal is created as it is required by the
protocol."
because it may not be created even if requested by the client, namely
if forbidden e.g. by PermitTTY.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Fixed s/sent/accepted/

Someone fixes the duplicated phase a while back.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2386

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.