openssh bugs - May 2022 - [Bug 3438] New: env var that is SetEnv'ed multiple times in the same SetEnv directive, is sent/printed several times

https://bugzilla.mindrot.org/show_bug.cgi?id=3438

            Bug ID: 3438
           Summary: env var that is SetEnv'ed multiple times in the same
                    SetEnv directive, is sent/printed several times
           Product: Portable OpenSSH
           Version: v9.0p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: calestyo at scientia.org

Hey.

Not sure whether this is a bug, but I guess so.

When doing e.g.
  SetEnv LC_ALL=C
  SetEnv LC_ALL=C.UTF-8

only the former will show up in e.g. -G as:
  setenv LC_ALL=C
respectively -v as:
  debug1: channel 0: setting env LC_ALL = "C"

which is, I guess, as it should be.

However, when using:
  SetEnv LC_ALL=C LC_ALL=C.UTF-8

-G will give:
setenv LC_ALL=C
setenv LC_ALL=C.UTF-8

and -v:
  debug1: channel 0: setting env LC_ALL = "C"
  debug1: channel 0: setting env LC_ALL = "C.UTF-8"

and in the remote shell, the env var is actually set to the latter
("C.UTF-8").
If actually desired, than at least this should be documented in SetEnv.

And -G should probably only print the one line that actually matters.


Thanks,
Chris.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3438

Colin Watson <cjwatson at debian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cjwatson at debian.org

--- Comment #1 from Colin Watson <cjwatson at debian.org> ---
This bug is referenced in the changelog for OpenSSH 9.1/9.1p1 as being
fixed in that release:

 * ssh(1), sshd(8): SetEnv directives in ssh_config and sshd_config
   are now first-match-wins to match other directives. Previously
   if an environment variable was multiply specified the last set
   value would have been used. bz3438

Should it be closed?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3438

--- Comment #2 from Christoph Anton Mitterer <calestyo at scientia.org>
---
I've just verified this with Colin's fresh openssh-client 1:9.1p1-1:

When set in ssh_config as:
  SetEnv LC_ALL=C
  SetEnv LC_ALL=C.UTF-8

one now gets:
  setenv LC_ALL=C
in -G and in -v:
  debug1: channel 0: setting env LC_ALL = "C"


And without the following in the config:
  SetEnv LC_ALL=C LC_ALL=C.UTF-8
one now gets:
  setenv LC_ALL=C
in -G and in -v:
  debug1: channel 0: setting env LC_ALL = "C"


So I can confirm it's been fixed.


I'll leave it open for now, cause maybe ssh upstream wants to add some
documentation?


Cheers,
Chris.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3438

--- Comment #3 from Christoph Anton Mitterer <calestyo at scientia.org>
---
Shall I provide a patch that adds a line like:
"If the same variable is give multiple times, only it's first
occurrence is considered."

to SetEnv / SendEnv?

However, for SendEnv it would be interesting if this is actually the
case there as well, and especially if there's a "clearing" entry
like
in:

SendEnv FOO BAR FOO BAZ -FOO

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3438

github at kalvdans.no-ip.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |github at kalvdans.no-ip.org

-- 
You are receiving this mail because:
You are watching the assignee of the bug.