Paul C. Anagnostopoulos via llvm-dev
2020-Sep-22 19:43 UTC
[llvm-dev] Now I really have broken the build
Okay, I've got two patches ready to fix my two problems. Do I simply make another commit and push it?
Arthur Eubanks via llvm-dev
2020-Sep-22 19:51 UTC
[llvm-dev] Now I really have broken the build
Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue. On Tue, Sep 22, 2020 at 12:43 PM Paul C. Anagnostopoulos via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Okay, I've got two patches ready to fix my two problems. Do I simply make > another commit and push it? > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200922/39347c2f/attachment.html>
Paul C. Anagnostopoulos via llvm-dev
2020-Sep-22 19:54 UTC
[llvm-dev] Now I really have broken the build
Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote:>Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.---------------------------------------------------------------- Windfall Paul C. Anagnostopoulos ---------------------------------------------------------- Software 978 369-0839 www.windfall.com ---------------------------------------------------------------- My life has been filled with calamities, some of which actually happened. ---Mark Twain Guga 'mzimba, sala 'nhliziyo