llvm dev - Apr 2020 - Pre-merge clang-format linter failing

Hi all,

I've noticed several patches that were updated overnight UK time where the
following message was produced by the Phabricator linter check:
"clang-format-diff not found in user's PATH; not linting file."
I'm
guessing that something has gone wrong on whatever bot does this?

James
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200402/f8a9dff8/attachment.html>

On Thu, Apr 2, 2020 at 3:48 AM James Henderson via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Hi all,
>
> I've noticed several patches that were updated overnight UK time where
the
> following message was produced by the Phabricator linter check:
> "clang-format-diff not found in user's PATH; not linting
file." I'm
> guessing that something has gone wrong on whatever bot does this?
>
In particular, if it is a user-side hook for arcanist,
`clang-format-diff.py` is in my PATH, but I still get that message.

>
> James
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200402/d42ef012/attachment.html>

The thing that has to be on your path has to be called clang-format-diff, not
clang-format-diff.py. It also can’t be a bash alias.

I create a symlink from my clang-format-diff.py to clang-format-diff and it
works for me.

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Hubert
Tong via llvm-dev
Sent: Thursday, April 2, 2020 6:03 AM
To: jh7370.2008 at my.bristol.ac.uk
Cc: llvm-dev <llvm-dev at lists.llvm.org>
Subject: [EXT] Re: [llvm-dev] Pre-merge clang-format linter failing

On Thu, Apr 2, 2020 at 3:48 AM James Henderson via llvm-dev <llvm-dev at
lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
Hi all,

I've noticed several patches that were updated overnight UK time where the
following message was produced by the Phabricator linter check:
"clang-format-diff not found in user's PATH; not linting file."
I'm guessing that something has gone wrong on whatever bot does this?
In particular, if it is a user-side hook for arcanist, `clang-format-diff.py` is
in my PATH, but I still get that message.


James
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200402/f037ad1e/attachment.html>