similar to: Pre-merge clang-format linter failing

Why isn’t it in the LLVM repo? > On Nov 16, 2016, at 7:44 AM, Johannes Doerfert <doerfert at cs.uni-saarland.de> wrote: > > We have a clang format based arcanist linter (and some others) in the > Polly repository. When arcanist is used to create a review, the linter > result is shown online. We also have an arcanist add-on to run the lit > tests and show their result in

So, I forwarded the request for highlighting trailing whitespaces to phabricator upstream (https://secure.phabricator.com/T11879), and upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we

Hi All, I just posted a review with arcanist (which I'm fairly new to) and it included a build status. How it got there is totally opaque to me, but my workflow was: Using git+svn (following the setup in https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn) make a change, commit with 'git commit', create review with 'air diff'. It would be cool if

On 11/14, Mehdi Amini via llvm-dev wrote: > Ideally I’d even really like to have a both checking for revision on > phab, clang-formatting them, and post a comment when there is a > mismatch :) I'd like that! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: Digital signature URL:

So some of you may be aware that Tim Sharpe from GitHub wrote a Puppet linting tool: $ gem install puppet-lint $ puppet-lint mymanifest.pp Source: https://github.com/rodjek/puppet-lint The linting tool checks Puppet code for "best practice" based on the Puppet Labs Style Guide: http://docs.puppetlabs.com/guides/style_guide.html A lot of us have been using puppet-lint (and puppet

Hi, One takeaway for me from the recent Phabricator vs Github PR discussions was that arc (arcanist) can be a pain to set up and may pose a hurdle for some contributors. I think those points could be addressed relatively easily by adding a llvm-patch script (or an even better name) that allows users to create and apply patches from reviews.llvm.org using Phabricators API. In my experience, the

Hi, I recently tried reviewing/committing some of my code on Phabricator/Arcanist for the first time and I noticed that the docs [1] ask for feedback, so here it is! Phabricator functions reasonably well and it is a lot easier to write comments and respond to comments on particular parts of code as opposed to the old way of copy and pasting patches into e-mails sent to llvm-commits. Two minors

+1 to this. I will not deny that, for whatever reason, people don't seem to use Arcanist. Using PHP as the scripting language seems to be a major sticking point for people, since it is not typically preinstalled or required for normal LLVM development, in the way that Python is. I've done it, and it works for me. I think it makes more sense to try and standardize on the existing tool

On Sun, Dec 27, 2015 at 10:59 PM, Manuel Klimek via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Dan, thanks for the feedback. > > On Mon, Dec 28, 2015 at 6:24 AM Dan Liew <dan at su-root.co.uk> wrote: > >> Hi, >> >> I recently tried reviewing/committing some of my code on >> Phabricator/Arcanist for the first time and I noticed that the docs

On Tue, Jan 7, 2020 at 5:35 PM Jonas Devlieghere <jonas at devlieghere.com> wrote: > On Tue, Jan 7, 2020 at 5:16 PM Bill Wendling via cfe-dev > <cfe-dev at lists.llvm.org> wrote: > > > > On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> > wrote: > >> > >> Hi Bill, > >> > >> On 01/07, Bill Wendling

On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> wrote: > I was always assuming that the suggested commit is assembled in the > PHP code run by arcanist command run locally. If indeed the arc > command requests the commit message from the server, I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data,

Hello, on a fresh install (i.e. newly-cloned arcanist and llvm-project), I get this. Any ideas? Thanks! arc install-certificate CONNECT Connecting to "https://reviews.llvm.org/api/"... Usage Exception: Failed to connect to server (https://reviews.llvm.org/api/): [HTTP/500] Internal Server Error As received by the server, this request had a nonzero content length but no POST data.

Hi, I have recently migrated (under emergency conditions) a dovecot imap/pop based server to a new instance. The mailboxes used mdbox format and due to various screwups I had corrupt indexes. I thought I'd cleaned this up but then I found that this new instance hadn't been set up correctly for nfs. Long story short, I still get users with new cases of corrupt indexes. The symptom is imap

Hi all, We upgraded phabricator to use HTTPS by default. All HTTP traffic will now be redirected to HTTPS. Arcanist users: Please run: $ *arc install-certificate* to re-install the certificate. Thanks, Eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160714/efc26c7f/attachment.html>

On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> wrote: > Hi Bill, > > On 01/07, Bill Wendling via llvm-dev wrote: > > Then perhaps those opposed could suggest how to use Phabricator/Arcanist > so > > that I don't throw my keyboard through my monitor? > > Please explain your problems, w/o the hyperbole, so people can actually do >

I thought so, initially. But I'm able to log in to reviews.llvm.org. Also, I assume install-certificate is before any of these considerations? On Wed, Apr 8, 2020 at 6:53 PM David Blaikie <dblaikie at gmail.com> wrote: > Hmm - I'm running a pretty old version & seems to be working for me: > > $ arc version > > arcanist 3b6b523c2b236e3724a1e115f126cb6fd05fa128 (18

On Sun, Oct 5, 2014 at 9:37 AM, Renato Golin <renato.golin at linaro.org> wrote: > On 5 October 2014 07:19, Saleem Abdulrasool <compnerd at compnerd.org> wrote: > > So with that in mind, I would like to ask, would it be possible to > consider > > switching to LLVM style for lld? > > We don't usually enforce code styles on side projects because it >

Hi, I tried to commit the Differential revision D3021 with the "arc commit" command. While it showed that the command succeeded and the Differential revision was closed, I can't find the revision anywhere in the SVN repository or the GIT mirror. Did I forget something? I tried a manual commit a few days ago and it worked. I've put the output of the "arc

On Wed, Jan 15, 2020 at 01:30:34PM -0600, David Greene via cfe-dev wrote: > Emilio Cobos Álvarez <emilio at crisal.io> writes: > > > [1] or [2] are recentish examples that come to mind, but it happens > > fairly often. Of course for a bunch of simpler changes one revision is > > enough. > > I think you forgot to include links. :) > > > The use cases

> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” > (and my dissident minority opinion that it is only