Johnson, Nicholas Paul via llvm-dev
2016-Jan-27 15:16 UTC
[llvm-dev] cmake: program name prefix?
Thanks all for replies. Krysztof said:>We do the exact same thing with our Hexagon compiler. The executables >that we ship are prefixed with hexagon-.Chris Bieneman said:>You also need changes to llc, opt (and any other tools you >want) so that they read the target triple from their names. >Chris' reply assumes that the prefix string must be a target triple and thus should be parsed by tools. It might be easier to do a halfway step: provide a PROGRAM_PREFIX option, but not require that the prefix string correspond to a target triple descriptor string. This sounds like it would also satisfy Krzysztof's use case (as "hexagon-" is not a target triple specifier anyway) and it would satisfy mine too. I am curious, would the project be interested in such a half-way patch? Nick
Krzysztof Parzyszek via llvm-dev
2016-Jan-29 16:57 UTC
[llvm-dev] cmake: program name prefix?
On 1/27/2016 9:16 AM, Johnson, Nicholas Paul via llvm-dev wrote:> > I am curious, would the project be interested in such a half-way patch?Given that there are two use cases already, I'd suggest that there is indeed an interest. Those who don't need this will probably not be actively interested, so as long as nobody objects, I'd say, let's do it. To recap: the proposal is to add a cmake argument PROGRAM_PREFIX=xyz, whose only function would be to prepend "xyz" to the names of all binaries installed through the "install" target. The default would be an empty string (or an unset value), so those who don't specify it won't see any change. Are there any objections to this? -Krzysztof -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> On 1/27/2016 9:16 AM, Johnson, Nicholas Paul via llvm-dev wrote: > > > > I am curious, would the project be interested in such a half-way patch? > > Given that there are two use cases already, I'd suggest that there is > indeed an interest. Those who don't need this will probably not be > actively interested, so as long as nobody objects, I'd say, let's do it. > > To recap: the proposal is to add a cmake argument PROGRAM_PREFIX=xyz, > whose only function would be to prepend "xyz" to the names of all > binaries installed through the "install" target. The default would be > an empty string (or an unset value), so those who don't specify it won't > see any change. > > Are there any objections to this?Not from here. FWIW we also rename the build products, currently in a separate packaging step that we do anyway. So, we're unlikely to take advantage of the feature ourselves, but it's certainly a reasonable thing to want. --paulr