On 24 February 2014 18:32, Daniel Dunbar <daniel at zuster.org> wrote:> $(error "ENDIAN is $ENDIAN"), before and after the include of > Makefile.config and Makefile.singlesrc (which includes Makefile.programs).Hi Daniel, Thanks, that did the trick! ;) In TargetConfig.mk.in: #ifdef __LITTLE_ENDIAN__ ENDIAN := little #else ENDIAN := big #endif Seems like it should be __ORDER_LITTLE_ENDIAN__ to be cross-platform. Attaching the patch that adds aarch64 (which is identical to the one applied in LLVM a few days ago) to the config plus change the TargetConfig.mk. Shouldn't cause too much disturbance. ;) cheers, --renato -------------- next part -------------- A non-text attachment was scrubbed... Name: test-suite-aarch64.patch Type: text/x-patch Size: 957 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140226/e777ffdc/attachment.bin>
Hi Renato, Daniel, This is related to a patch I submitted a little while ago (still pending): http://llvm-reviews.chandlerc.com/D2760 If accepted, would it make this patch (and a others) unnecessary? Robert ________________________________________ From: llvmdev-bounces at cs.uiuc.edu [llvmdev-bounces at cs.uiuc.edu] on behalf of Renato Golin [renato.golin at linaro.org] Sent: 26 February 2014 13:06 To: Daniel Dunbar Cc: LLVM Dev Subject: Re: [LLVMdev] test-suite wrongly using big-endian results On 24 February 2014 18:32, Daniel Dunbar <daniel at zuster.org> wrote:> $(error "ENDIAN is $ENDIAN"), before and after the include of > Makefile.config and Makefile.singlesrc (which includes Makefile.programs).Hi Daniel, Thanks, that did the trick! ;) In TargetConfig.mk.in: #ifdef __LITTLE_ENDIAN__ ENDIAN := little #else ENDIAN := big #endif Seems like it should be __ORDER_LITTLE_ENDIAN__ to be cross-platform. Attaching the patch that adds aarch64 (which is identical to the one applied in LLVM a few days ago) to the config plus change the TargetConfig.mk. Shouldn't cause too much disturbance. ;) cheers, --renato
On 26 February 2014 14:44, Robert Lytton <robert at xmos.com> wrote:> This is related to a patch I submitted a little while ago (still pending): > http://llvm-reviews.chandlerc.com/D2760 > > If accepted, would it make this patch (and a others) unnecessary?Hi Robert, It is, but hijacking your patch a little, why not use __ORDER_LITTLE_ENDIAN__? Why do we need to create __LITTLE_ENDIAN__ ? cheers, --renato