SelectionDAG is big enough to have multiple owners. Legalizer, dag combine, etc. can each have a separate owner. Evan On Nov 13, 2012, at 5:56 PM, Chris Lattner <clattner at apple.com> wrote:> On Nov 13, 2012, at 2:41 PM, Nadav Rotem <nrotem at apple.com> wrote: >> Owen Anderson and I would like to be the co-owners of SelectionDAG. > > I'm not a big fan of co-owners: how will you know which pieces you each are covering? Dan Gohman would be another candidate for owner of this area. Can we have only one owner? > > -Chris > > >> >> >> On Nov 13, 2012, at 2:29 PM, Chandler Carruth <chandlerc at google.com> wrote: >> >>> FWIW, I don't think we need any process for folks to be an owner of a >>> file (or collection of files) for which they are the primary author of >>> all of the code... >>> >>> On Tue, Nov 13, 2012 at 2:19 PM, Hal Finkel <hfinkel at anl.gov> wrote: >>>> Chris, >>>> >>>> I'd like to take code ownership of the BBVectorize code. Although not quite directory granularity (because the loop vectorizer is also in that directory), it is self-contained. >>>> >>>> Thanks again, >>>> Hal >>>> >>>> -- >>>> Hal Finkel >>>> Postdoctoral Appointee >>>> Leadership Computing Facility >>>> Argonne National Laboratory >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On Nov 13, 2012, at 11:43 PM, Evan Cheng <evan.cheng at apple.com> wrote:> SelectionDAG is big enough to have multiple owners. Legalizer, dag combine, etc. can each have a separate owner.I don't think that makes sense given our model of code owner. The important task here is ensuring that each piece gets reviewed. Splitting things up at such a fine level doesn't help with that. -Chris> > Evan > > On Nov 13, 2012, at 5:56 PM, Chris Lattner <clattner at apple.com> wrote: > >> On Nov 13, 2012, at 2:41 PM, Nadav Rotem <nrotem at apple.com> wrote: >>> Owen Anderson and I would like to be the co-owners of SelectionDAG. >> >> I'm not a big fan of co-owners: how will you know which pieces you each are covering? Dan Gohman would be another candidate for owner of this area. Can we have only one owner? >> >> -Chris >> >> >>> >>> >>> On Nov 13, 2012, at 2:29 PM, Chandler Carruth <chandlerc at google.com> wrote: >>> >>>> FWIW, I don't think we need any process for folks to be an owner of a >>>> file (or collection of files) for which they are the primary author of >>>> all of the code... >>>> >>>> On Tue, Nov 13, 2012 at 2:19 PM, Hal Finkel <hfinkel at anl.gov> wrote: >>>>> Chris, >>>>> >>>>> I'd like to take code ownership of the BBVectorize code. Although not quite directory granularity (because the loop vectorizer is also in that directory), it is self-contained. >>>>> >>>>> Thanks again, >>>>> Hal >>>>> >>>>> -- >>>>> Hal Finkel >>>>> Postdoctoral Appointee >>>>> Leadership Computing Facility >>>>> Argonne National Laboratory >>>>> _______________________________________________ >>>>> LLVM Developers mailing list >>>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On Nov 14, 2012, at 10:59 AM, Chris Lattner <clattner at apple.com> wrote:> > On Nov 13, 2012, at 11:43 PM, Evan Cheng <evan.cheng at apple.com> wrote: > >> SelectionDAG is big enough to have multiple owners. Legalizer, dag combine, etc. can each have a separate owner. > > I don't think that makes sense given our model of code owner. The important task here is ensuring that each piece gets reviewed. Splitting things up at such a fine level doesn't help with that.Ok. Then I nominate Owen. SelectionDAG needs a code owner. Instcombine also needs one. Would Eli like to serve as code owner? Andy Trick - loop strength reduction? Now that my domain is quickly being taken over by folks, I suppose I need to clarify what I own. :) If there are no objections, I will take ARM target and parts of code generator that are not covered by anyone else. Evan> > -Chris > >> >> Evan >> >> On Nov 13, 2012, at 5:56 PM, Chris Lattner <clattner at apple.com> wrote: >> >>> On Nov 13, 2012, at 2:41 PM, Nadav Rotem <nrotem at apple.com> wrote: >>>> Owen Anderson and I would like to be the co-owners of SelectionDAG. >>> >>> I'm not a big fan of co-owners: how will you know which pieces you each are covering? Dan Gohman would be another candidate for owner of this area. Can we have only one owner? >>> >>> -Chris >>> >>> >>>> >>>> >>>> On Nov 13, 2012, at 2:29 PM, Chandler Carruth <chandlerc at google.com> wrote: >>>> >>>>> FWIW, I don't think we need any process for folks to be an owner of a >>>>> file (or collection of files) for which they are the primary author of >>>>> all of the code... >>>>> >>>>> On Tue, Nov 13, 2012 at 2:19 PM, Hal Finkel <hfinkel at anl.gov> wrote: >>>>>> Chris, >>>>>> >>>>>> I'd like to take code ownership of the BBVectorize code. Although not quite directory granularity (because the loop vectorizer is also in that directory), it is self-contained. >>>>>> >>>>>> Thanks again, >>>>>> Hal >>>>>> >>>>>> -- >>>>>> Hal Finkel >>>>>> Postdoctoral Appointee >>>>>> Leadership Computing Facility >>>>>> Argonne National Laboratory >>>>>> _______________________________________________ >>>>>> LLVM Developers mailing list >>>>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >