llvm dev - Oct 2012 - [LLVMdev] [PATCH / PROPOSAL] bitcode encoding that is ~15% smaller for large bitcode files...

On Sat, Oct 6, 2012 at 8:32 AM, Rafael Espíndola <rafael.espindola at
gmail.com
> wrote:
>
> +static void EmitSignedInt64(SmallVectorImpl<uint64_t> &Vals,
uint64_t V) {
>
> Please start function names with a lower case letter.
>
>
Done -- changed this function and most of the "pushValue" functions. 
I
left PushValueAndType alone since that is an existing function and it
seemed like that would introduce other unrelated changes.

> +EnableOldStyleFunctions("enable-old-style-functions",
>
> Maybe something like use-abs-operands is a better name now that this
> is a global setting, no?
>
Yes that would be more descriptive.  Changed in new patch.

>
> > - Jan
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121008/0599d7ba/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: relative_ids.patch5
Type: application/octet-stream
Size: 38577 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121008/0599d7ba/attachment.obj>

This looks good to me.

Just one question, you found that forward references are only common
with phi operands, so it is not profitable to use a signed
representation for other operands, right?

Cheers,
Rafael

Yes, I had about 133K hits for INST_PHI with a negative value, out of 136K
hits of any "INST_.*" with a negative valued operand.

Overall there were 474K INST_PHI and 12 million "INST_.*" in my tests.

- Jan


On Wed, Oct 10, 2012 at 11:23 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> This looks good to me.
>
> Just one question, you found that forward references are only common
> with phi operands, so it is not profitable to use a signed
> representation for other operands, right?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121010/9b388cef/attachment.html>