llvm dev - Sep 2012 - [LLVMdev] Proposal: New IR instruction for casting between address spaces

From: Villmow, Micah
Sent: Tuesday, September 11, 2012 12:51 PM
To: llvm-commits at cs.uiuc.edu
Subject: Proposal: New IR instruction for casting between address spaces

Problem:
Bit casting between pointers of different address spaces only works if all
address space pointers are the same size. With changes from email chain [1][2],
support for different pointer sizes breaks the bitcast instruction since there
is no guarantee that the pointer size for the address space is on the source and
destination arguments are of the same size.

Solution:
Remove the ability of bitcast to cast between pointers of different address
spaces and replace with an instruction that handles this case explicitely.

Proposed changes:

*         Add restriction to the verifier on the bitcast instruction making
bitcasting between address spaces illegal.

*         Change documentation[3] to state the bitcast to pointers of different
address spaces is illegal.

*         Add in a new IR node, addrspacecast, that allows conversions between
address spaces

*         Updated the reader/writer to handle these cases

*         Update the documentation to insert the new IR node.

*         Add the following documentation:

'addrspacecast .. to' Instruction
Syntax:

  <result> = addrspacecast <ty> <value> to <ty2>        
; yields ty2

Overview:

The ' addrspacecast ' instruction converts value to type ty2 without
changing any bits.

Arguments:

The ' addrspacecast ' instruction takes a value to cast, which must be a
non-aggregate first class value with a pointer type, and a type to cast it to,
which must also be a pointer type. The pointer types of value and the
destination type, ty2, must be identical, except for the address space.

Semantics:

The ' addrspacecast ' instruction converts value to type ty2. It
converts the type to the type that is implied by the address space of the
destination pointer. If the destination pointer is smaller than the source
pointer, the upper bits are truncated. If the inverse is true, the upper bits
are sign extended, otherwise the operation is a no-op.

Example:

  %X = addrspacecast i8 addrspace(1) 255 to i8* addrspace(2)              ;
yields i8* addrspace(2) :-1

  %Y = addrspacecast i32* %x to sint* addrspace(31)          ; yields sint*
addrspace(31):%x



Thanks,

Micah


[1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-September/053166.html
[2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-August/052639.html
[3] http://llvm.org/docs/LangRef.html#i_bitcast


-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120911/c437fcbd/attachment.html>

On Sep 11, 2012, at 1:03 PM, "Villmow, Micah" <Micah.Villmow at
amd.com> wrote:
>  
> From: Villmow, Micah 
> Sent: Tuesday, September 11, 2012 12:51 PM
> To: llvm-commits at cs.uiuc.edu
> Subject: Proposal: New IR instruction for casting between address spaces
>  
> Problem:
> Bit casting between pointers of different address spaces only works if all
address space pointers are the same size. With changes from email chain [1][2],
support for different pointer sizes breaks the bitcast instruction since there
is no guarantee that the pointer size for the address space is on the source and
destination arguments are of the same size.
Can you comment on whether the need for this seems like a fundamental
need, in your field, or more of a limitation of the current generation of
architectures?
> Solution:
> Remove the ability of bitcast to cast between pointers of different address
spaces and replace with an instruction that handles this case explicitely.
>  
> Proposed changes:
> ·         Add restriction to the verifier on the bitcast instruction making
bitcasting between address spaces illegal.
> ·         Change documentation[3] to state the bitcast to pointers of
different address spaces is illegal.
> ·         Add in a new IR node, addrspacecast, that allows conversions
between address spaces
> ·         Updated the reader/writer to handle these cases
> ·         Update the documentation to insert the new IR node.
> ·         Add the following documentation:
> 'addrspacecast .. to' Instruction
> 
> Syntax:
> 
>   <result> = addrspacecast <ty> <value> to <ty2>   
; yields ty2
> Overview:
> 
> The ' addrspacecast ' instruction converts value to type ty2
without changing any bits.
This is mildly imprecise, because the whole point of this instruction is that
it can change the bit width.
> 
> Arguments:
> 
> The ' addrspacecast ' instruction takes a value to cast, which must
be a non-aggregate first class value with a pointer type, and a type to cast it
to, which must also be a pointer type. The pointer types of value and the
destination type, ty2, must be identical, except for the address space.
Having a "pointer type" is sufficient to imply that it is a
"non-aggregate first class value".
> 
> Semantics:
> 
> The ' addrspacecast ' instruction converts value to type ty2. It
converts the type to the type that is implied by the address space of the
destination pointer. If the destination pointer is smaller than the source
pointer, the upper bits are truncated. If the inverse is true, the upper bits
are sign extended, otherwise the operation is a no-op.
Why sign-extended? Ptrtoint/inttoptr are zero-extended, and it's surprising
that addrspacecast would be different from them.

Dan

> -----Original Message-----
> From: Dan Gohman [mailto:gohman at apple.com]
> Sent: Tuesday, September 11, 2012 1:28 PM
> To: Villmow, Micah
> Cc: llvmdev at cs.uiuc.edu
> Subject: Re: [LLVMdev] Proposal: New IR instruction for casting between
> address spaces
> 
> On Sep 11, 2012, at 1:03 PM, "Villmow, Micah" <Micah.Villmow
at amd.com>
> wrote:
> 
> >
> > From: Villmow, Micah
> > Sent: Tuesday, September 11, 2012 12:51 PM
> > To: llvm-commits at cs.uiuc.edu
> > Subject: Proposal: New IR instruction for casting between address
> > spaces
> >
> > Problem:
> > Bit casting between pointers of different address spaces only works if
> all address space pointers are the same size. With changes from email
> chain [1][2], support for different pointer sizes breaks the bitcast
> instruction since there is no guarantee that the pointer size for the
> address space is on the source and destination arguments are of the same
> size.
> 
> Can you comment on whether the need for this seems like a fundamental
> need, in your field, or more of a limitation of the current generation
> of architectures?
[Villmow, Micah] I think this is a little of both. While the current and
previous generation of GPU architectures are limited in what they are capable of
doing based on hardware restrictions, I also think there is a fundamental need.
Not all devices will run with 64bit operations at full speed(or even have native
instructions in any case), but memory sizes will soon eclipse what is
addressable with 32bit pointers on non-PC systems. What this is causing is 32bit
systems requiring addressing into 64bit memory and switching over to 64bit for
address calculations destroys the performance advantage that the segmented
memory provides.
In the CPU world, this isn't that much of a problem that I can tell as they
have already been solved(32bit vs 64bit math is 1-1 in most cases), but in
non-CPU architectures, this is a huge performance penalty(64bit mul runs 6x
slower than 32bit mul). So being able to switch to 32bit in the cases where it
is required and switch to 64bit where it is required is a fundamental need that
I don't think will go away even if the architectures improve their memory
infrastructure.
> 
> > Solution:
> > Remove the ability of bitcast to cast between pointers of different
> address spaces and replace with an instruction that handles this case
> explicitely.
> >
> > Proposed changes:
> > *         Add restriction to the verifier on the bitcast instruction
> making bitcasting between address spaces illegal.
> > *         Change documentation[3] to state the bitcast to pointers of
> different address spaces is illegal.
> > *         Add in a new IR node, addrspacecast, that allows conversions
> between address spaces
> > *         Updated the reader/writer to handle these cases
> > *         Update the documentation to insert the new IR node.
> > *         Add the following documentation:
> > 'addrspacecast .. to' Instruction
> >
> > Syntax:
> >
> >   <result> = addrspacecast <ty> <value> to
<ty2>             ; yields
> ty2
> > Overview:
> >
> > The ' addrspacecast ' instruction converts value to type ty2
without
> changing any bits.
> 
> This is mildly imprecise, because the whole point of this instruction is
> that it can change the bit width.
[Villmow, Micah] Doh, cut and paste error, will fix it.
> 
> >
> > Arguments:
> >
> > The ' addrspacecast ' instruction takes a value to cast, which
must be
> a non-aggregate first class value with a pointer type, and a type to
> cast it to, which must also be a pointer type. The pointer types of
> value and the destination type, ty2, must be identical, except for the
> address space.
> 
> Having a "pointer type" is sufficient to imply that it is a
"non-
> aggregate first class value".
> 
> >
> > Semantics:
> >
> > The ' addrspacecast ' instruction converts value to type ty2.
It
> converts the type to the type that is implied by the address space of
> the destination pointer. If the destination pointer is smaller than the
> source pointer, the upper bits are truncated. If the inverse is true,
> the upper bits are sign extended, otherwise the operation is a no-op.
> 
> Why sign-extended? Ptrtoint/inttoptr are zero-extended, and it's
> surprising that addrspacecast would be different from them.
[Villmow, Micah] Take for example a pointer representing a negative pointer
offset into a 16 bit address space, if this is converted to a 64bit address
space, the upper 48 bits would be zero and your negative offset just became
positive. The difference between these two instruction types is that
addrspacecast does not explicitly convert to any size, only implicitly, so the
bits would need to be filled correctly.
> 
> Dan
>