llvm dev - Jul 2012 - [LLVMdev] Fix for "Bad fd number" error in test_debuginfo.pl

Hi,

Please could someone kindly review this patch for me?

Many thanks
Andy


On Wednesday, July 18, 2012 4:29 PM, Andy Gibbs wrote:
> Hi,
> 
> Attached is a simple patch to fix a "Bad fd number" error in
> test_debuginfo.pl which has come about because of an invalid redirection
> in the system call.
> 
> Normally the stdout+stderr to file redirection is "&>"
(not ">&" as in
> the script!), but I have found this to be unsupported on all shell types
> (I think it was introduced in bash at version 4, for example), so the
> more portable "> file 2>&1" has been substituted.
> 
> Cheers
> Andy
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.diff
Type: application/octet-stream
Size: 638 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120723/42317670/attachment.obj>

Hi Andy,
> Please could someone kindly review this patch for me?
LGTM.

Ciao, Duncan.
>
> Many thanks
> Andy
>
>
> On Wednesday, July 18, 2012 4:29 PM, Andy Gibbs wrote:
>> Hi,
>>
>> Attached is a simple patch to fix a "Bad fd number" error in
>> test_debuginfo.pl which has come about because of an invalid
redirection
>> in the system call.
>>
>> Normally the stdout+stderr to file redirection is "&>"
(not ">&" as in
>> the script!), but I have found this to be unsupported on all shell
types
>> (I think it was introduced in bash at version 4, for example), so the
>> more portable "> file 2>&1" has been substituted.
>>
>> Cheers
>> Andy
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>