llvm dev - Jun 2012 - [LLVMdev] [PATCH] Moving DebugInfo module to VMCore

Hi all,

This patch, though large, simply moves lib/Analysis/DebugInfo.cpp to
lib/VMCore/DebugInfo.cpp and include/llvm/Analysis/DebugInfo.h to
include/llvm/DebugInfo.h.

Why? Because this module has nothing to do with analysis. It simply defines an
interface to the debug info MDNodes. In fact, the lib/VMCore/AsmWriter.cpp file
performs a layering violation, because it calculates the DWARF tag from this
debug info, which is more appropriately calculated via the debug info module. It
could eventually allow us to use the debug info module's comment printer to
generate fuller comments in the .ll file.

Okay to commit?

-bw

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-debuginfo.patch
Type: application/octet-stream
Size: 2168 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120627/96bc1f83/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debuginfo.patch
Type: application/octet-stream
Size: 104485 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120627/96bc1f83/attachment-0001.obj>
-------------- next part --------------

On Jun 27, 2012, at 4:08 PM, Bill Wendling <wendling at apple.com> wrote:
> Hi all,
> 
> This patch, though large, simply moves lib/Analysis/DebugInfo.cpp to
lib/VMCore/DebugInfo.cpp and include/llvm/Analysis/DebugInfo.h to
include/llvm/DebugInfo.h.
> 
> Why? Because this module has nothing to do with analysis. It simply defines
an interface to the debug info MDNodes. In fact, the lib/VMCore/AsmWriter.cpp
file performs a layering violation, because it calculates the DWARF tag from
this debug info, which is more appropriately calculated via the debug info
module. It could eventually allow us to use the debug info module's comment
printer to generate fuller comments in the .ll file.
> 
> Okay to commit?
> 
> -bw
> 
> <clang-debuginfo.patch><debuginfo.patch>
Sure, I'm ok with that.

-eric

On Jun 27, 2012, at 4:20 PM, Eric Christopher wrote:
> 
> On Jun 27, 2012, at 4:08 PM, Bill Wendling <wendling at apple.com>
wrote:
> 
>> Hi all,
>> 
>> This patch, though large, simply moves lib/Analysis/DebugInfo.cpp to
lib/VMCore/DebugInfo.cpp and include/llvm/Analysis/DebugInfo.h to
include/llvm/DebugInfo.h.
>> 
>> Why? Because this module has nothing to do with analysis. It simply
defines an interface to the debug info MDNodes. In fact, the
lib/VMCore/AsmWriter.cpp file performs a layering violation, because it
calculates the DWARF tag from this debug info, which is more appropriately
calculated via the debug info module. It could eventually allow us to use the
debug info module's comment printer to generate fuller comments in the .ll
file.
>> 
>> Okay to commit?
>> 
>> -bw
>> 
>> <clang-debuginfo.patch><debuginfo.patch>
> 
> Sure, I'm ok with that.
> 
Done. Thanks!

-bw