Jay Foad
2011-Jul-05 09:48 UTC
[LLVMdev] [type-system-rewrite][PATCH] de-constify Type* in FunctionType::get()
This patch removes the deprecated form of FunctionType::get() which takes "const Type*"s for the argument types, and replaces just enough "const Type*" with "Type*" elsewhere to get everything building cleanly again. (My motivation for this was that I was getting ambiguous overload errors from some calls to FunctionType::get() in the Clang source.) Chris, are you interested in having this committed on the branch? Thanks, Jay. -------------- next part -------------- A non-text attachment was scrubbed... Name: deconstify-type.diff Type: text/x-patch Size: 39693 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110705/d9bb2fa2/attachment.bin>
Chris Lattner
2011-Jul-05 19:58 UTC
[LLVMdev] [type-system-rewrite][PATCH] de-constify Type* in FunctionType::get()
Sure, go for it. FWIW, I was waiting to do this (eventually "const Type" will just be "Type" everywhere). I have a long list of cleanups that I want to land after the branch lands... but I was waiting for after the branch lands to make merging it less annoying and make things more incremental. Unfortunately I'm struggling to find time to finish things up and land the branch (this week for sure! :). Since you've already done this work, go ahead and land it if you'd like. -Chris On Jul 5, 2011, at 2:48 AM, Jay Foad wrote:> This patch removes the deprecated form of FunctionType::get() which > takes "const Type*"s for the argument types, and replaces just enough > "const Type*" with "Type*" elsewhere to get everything building > cleanly again. (My motivation for this was that I was getting > ambiguous overload errors from some calls to FunctionType::get() in > the Clang source.) > > Chris, are you interested in having this committed on the branch? > > Thanks, > Jay. > <deconstify-type.diff>
Jay Foad
2011-Jul-06 08:33 UTC
[LLVMdev] [type-system-rewrite][PATCH] de-constify Type* in FunctionType::get()
> I have a long list of cleanups that I want to land after the branch lands... but I was waiting for after the branch lands to make merging it less annoying and make things more incremental. Unfortunately I'm struggling to find time to finish things up and land the branch (this week for sure! :).I'll wait until after the big merge-to-trunk then (unless anyone really wants it on the branch now!). Thanks, Jay.
Seemingly Similar Threads
- [LLVMdev] [type-system-rewrite][PATCH] de-constify Type* in FunctionType::get()
- [LLVMdev] type-system-rewrite branch landing tomorrow
- [LLVMdev] type-system-rewrite branch landing tomorrow
- [LLVMdev] What is a FunctionType really?
- [LLVMdev] FunctionType as a function argument