On Thursday 25 February 2010 16:07:59 Chris Lattner wrote:> On Feb 25, 2010, at 12:01 PM, David Greene wrote: > > I am seeing a whole lot of failures in the tests on trunk. From > > discussions with Chris and others, I should not be seeing this. > > Does 'make check-lit' pass for you in llvm/test?Nope. In fact I am seeing more failures in debug mode now. But what does "pass" mean? [x86_64-off-opt]: Testing Time: 127.55s [x86_64-off-opt]: Expected Passes : 5006 [x86_64-off-opt]: Expected Failures : 33 [x86_64-off-opt]: Unsupported Tests : 66 Is that really passing? Even though I see a bunch of "FAIL:" lines in the make output? Not 33 of them, however. -Dave
On Thursday 25 February 2010 16:17:10 David Greene wrote:> On Thursday 25 February 2010 16:07:59 Chris Lattner wrote: > > On Feb 25, 2010, at 12:01 PM, David Greene wrote: > > > I am seeing a whole lot of failures in the tests on trunk. From > > > discussions with Chris and others, I should not be seeing this. > > > > Does 'make check-lit' pass for you in llvm/test? > > Nope. In fact I am seeing more failures in debug mode now.And curiously, none in Release mode. No FAIL messages anyway. I still see this: [x86_64-off-opt]: Expected Passes : 5006 [x86_64-off-opt]: Expected Failures : 33 [x86_64-off-opt]: Unsupported Tests : 66 [x86_64-off-dbg]: Expected Passes : 5001 [x86_64-off-dbg]: Expected Failures : 33 [x86_64-off-dbg]: Unsupported Tests : 66 [x86_64-off-dbg]: Unexpected Failures: 5 Why would changing the test harness change the result of the tests? -Dave
On Feb 25, 2010, at 2:24 PM, David Greene wrote:> On Thursday 25 February 2010 16:17:10 David Greene wrote: >> On Thursday 25 February 2010 16:07:59 Chris Lattner wrote: >>> On Feb 25, 2010, at 12:01 PM, David Greene wrote: >>>> I am seeing a whole lot of failures in the tests on trunk. From >>>> discussions with Chris and others, I should not be seeing this. >>> >>> Does 'make check-lit' pass for you in llvm/test? >> >> Nope. In fact I am seeing more failures in debug mode now. > > And curiously, none in Release mode. No FAIL messages anyway. I > still see this: > > [x86_64-off-opt]: Expected Passes : 5006 > [x86_64-off-opt]: Expected Failures : 33 > [x86_64-off-opt]: Unsupported Tests : 66 > > [x86_64-off-dbg]: Expected Passes : 5001 > [x86_64-off-dbg]: Expected Failures : 33 > [x86_64-off-dbg]: Unsupported Tests : 66 > [x86_64-off-dbg]: Unexpected Failures: 5 > > Why would changing the test harness change the result of the tests?It's hard to know without knowing exactly what tests are failing and how. -Chris
On Feb 25, 2010, at 2:24 PM, David Greene wrote:> On Thursday 25 February 2010 16:17:10 David Greene wrote: >> On Thursday 25 February 2010 16:07:59 Chris Lattner wrote: >>> On Feb 25, 2010, at 12:01 PM, David Greene wrote: >>>> I am seeing a whole lot of failures in the tests on trunk. From >>>> discussions with Chris and others, I should not be seeing this. >>> >>> Does 'make check-lit' pass for you in llvm/test? >> >> Nope. In fact I am seeing more failures in debug mode now. > > And curiously, none in Release mode. No FAIL messages anyway. I > still see this: > > [x86_64-off-opt]: Expected Passes : 5006 > [x86_64-off-opt]: Expected Failures : 33 > [x86_64-off-opt]: Unsupported Tests : 66 > > [x86_64-off-dbg]: Expected Passes : 5001 > [x86_64-off-dbg]: Expected Failures : 33 > [x86_64-off-dbg]: Unsupported Tests : 66 > [x86_64-off-dbg]: Unexpected Failures: 5 > > Why would changing the test harness change the result of the tests?SDUse::setInitial should initialize List to null in your patch. You're probably seeing random uninitialized data noise without that. (Though valgrind wouldn't notice this because of the aggressive reuse of allocated memory.) Also, the replacement getOperandNo is returning the index in the use list, rather than the index in the operand array. Dan