I've included a patch which does not remove mkpatch but does remove diff search directories which caused a failure because those directories were no longer in svn. I was uncomfortable removing mkpatch since I believe it helps document creating patches for beginners who do not use separate source and build (object) root directories. Its existence is also expected by readers of: http://llvm.org/docs/DeveloperPolicy.html#patches. Garrison -------------- next part -------------- A non-text attachment was scrubbed... Name: mkpatch.patch Type: application/octet-stream Size: 701 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100115/b1990eea/attachment.obj>
On Jan 15, 2010, at 6:12 PM, Garrison Venn wrote:> I've included a patch which does not remove mkpatch but does remove > diff search > directories which caused a failure because those directories were no > longer > in svn. I was uncomfortable removing mkpatch since I believe it > helps document > creating patches for beginners who do not use separate source and > build (object) > root directories. Its existence is also expected by readers of: http://llvm.org/docs/DeveloperPolicy.html#patches > .Applied in r93771, thanks!