Matthijs Kooijman
2008-May-14 14:31 UTC
[LLVMdev] test/LLVMC should be guarded by a check for llvm-gcc/llvm-g++
Hi, I'm currenly working with clang, so I don't have any llvm-gcc installed (I used to have the 4.2 release version, but that broke a lot of tests). A number of tests (test/CFrontend and test/C++Frontend for example) won't run if you don't have llvm-gcc installed, which is good. However, the test/LLVMC tests do run, but fail. These tests test the llvmc2 compiler driver, but they can't work when llvm-gcc is not available. The attached patch adds guards to test/LLVMC/dg.exp, causing the errors to go away in my installation. I haven't tested this with llvm-gcc installed, but I assume that that will also work just fine. To prevent people from having to compile all of llvm-gcc only for getting the llvm tests to work, could you apply this patch? Gr. Matthijs -------------- next part -------------- A non-text attachment was scrubbed... Name: llvmc-guard.diff Type: text/x-diff Size: 485 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080514/633f5cc3/attachment.diff> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080514/633f5cc3/attachment.sig>
Tanya M. Lattner
2008-May-14 17:38 UTC
[LLVMdev] test/LLVMC should be guarded by a check for llvm-gcc/llvm-g++
Applied. http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062429.html This will go into the release branch too. Thanks! -Tanya On Wed, 14 May 2008, Matthijs Kooijman wrote:> Hi, > > I'm currenly working with clang, so I don't have any llvm-gcc installed (I > used to have the 4.2 release version, but that broke a lot of tests). A number > of tests (test/CFrontend and test/C++Frontend for example) won't run if you > don't have llvm-gcc installed, which is good. > > However, the test/LLVMC tests do run, but fail. These tests test the llvmc2 > compiler driver, but they can't work when llvm-gcc is not available. The > attached patch adds guards to test/LLVMC/dg.exp, causing the errors to go away > in my installation. I haven't tested this with llvm-gcc installed, but I > assume that that will also work just fine. > > To prevent people from having to compile all of llvm-gcc only for getting the > llvm tests to work, could you apply this patch? > > Gr. > > Matthijs >