Yes, you are probably right.
Evan
On May 8, 2008, at 3:31 PM, David Greene wrote:
> At line 1155 of LiveIntervalAnalysis.cpp (in
> LiveIntervals::rewriteInstructionsForSpills), should the condition
> be:
>
> if (ImpUse && MI != ReMatDefMI && MI != ReMatOrigDefMI)
>
> instead of:
>
> if (ImpUse && MI != ReMatDefMI)
>
> ?
>
> After all, ReMatDefMI is a clone of the original def instruction
> (ReMatOrigDefMI). I'm seeing bad things happen, with intervals
> getting HUGE_VALF set as their weight because they happen to
> be used in RegMatOrigDefMI and MI doesn't match ReMatDefMI
> (because it's a clone and not really in the IR at all!).
>
> -Dave
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev