netfilter buglog - Oct 2013 - [Bug 856] New: configure is checking kernel stuff even when the kmod build was disabled

https://bugzilla.netfilter.org/show_bug.cgi?id=856

           Summary: configure is checking kernel stuff even when the kmod
                    build was disabled
           Product: ipset
           Version: unspecified
          Platform: x86_64
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: default
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: bochecha at fedoraproject.org
   Estimated Hours: 0.0


Created attachment 414
  --> https://bugzilla.netfilter.org/attachment.cgi?id=414
configure: Reindent the --with-kmod checks

Looking at the source cod,e it seems all this stuff is only used in the kernel
module that is part of the ipset tarball.

So the checks shouldn't be run unconditionally.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=856

--- Comment #1 from Mathieu Bridon <bochecha at fedoraproject.org>
2013-10-09 10:08:03 CEST ---
Created attachment 415
  --> https://bugzilla.netfilter.org/attachment.cgi?id=415
configure: Move the kernel check in the with-kmod part

This is the actual patch that fixes this issue.

The previous patch is really just making the configure script easier to
understand, which comes in handy with this patch applied as the section
conditionned on the WITH_KMOD flag becomes incredibly long.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=856

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kadlec at netfilter.org

--- Comment #2 from Jozsef Kadlecsik <kadlec at netfilter.org> 2013-10-18
14:08:23 CEST ---
Oliver Smith noticed it and submitted a simpler patch, and I applied that.
Thanks for the bugreport and the patch too.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=856

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.