search for: reindent

...e: > > > > This is a known problem, I just haven't had time to do anything about > it yet (had my final exam today). > > >The patch is a small change but looks longer because I indented the > >code. > > Well... don't do that, then. Patches that do mass reindenting will > always be rejected, unless there's a REALLY good reason to do so > (you not liking my indentation style is a very poor reason). I didn't do a massive reindenting. I reindented just that small part of the code. I thought it was a mess. Was it supposed to be like that? >...

Signed-off-by: Adalbert Laz?r <alazar at bitdefender.com> --- arch/x86/kvm/mmu/mmu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 97766f34910d..f3ba4d0452c9 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -2573,6 +2573,7 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu,

The icecast2 code uses recv(2) to read data from a source and tests its returning value to see if something went wrong. The current code groups together two checks of the return value: - Returning 0 - Returning -1 and a non-recoverable error and gives the same error message for both. Since returning 0 means the connection has ended the following debug message showed up in error.log: DBUG

...note: ...this 'if' clause, but it is not if ( __get_cpu_var(poll_bankmask) == NULL ) ^~ I was unable to reproduce (xen builds cleanly for me with "6.0.0 20160117 (experimental) [trunk revision 232481]") but looking at the code the issue above is clearly real. Correctly reindent the if statement. This file uses Linux coding style (infact the use of Xen style for this line is the root cause of the wanring) so use tabs and while there remove the whitespace inside the if as Linux does. [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166 Signed-off-by: Ian Campbell...

...sier to use >> an attribute((cleanup)) handler to deal with the unlocking. See these >> links for how we do it in libguestfs: > > Oh cool! Yes, that looks nicer. Although the diffstat for doing so is > larger, because it requires adding to new sub-function {} scopes and > reindenting (we have two different locks in play here). > Interestingly, it doesn't compile if you lack attribute((cleanup)). Libguestfs has: common/utils/cleanups.h:/* XXX no safe equivalent to CLEANUP_GL_RECURSIVE_LOCK_UNLOCK */ and will fail to compile if the compiler lacks the attribute - arg...

(emacs newb here) After having made some changes in an \items paragraph of \arguments the lines are no longer nicely wrapped. I was looking for a command to reindent/rewrap/reformat the whole \items paragraph but couldn't find anything. The only way, I found, was to go to the end of the first line, do 'c-j' (or RET) which wraps *this* line nicely, but now there is a hard line-break to the next line. So I go back with 'c-p', delete the gap...

...any.exe or pvvxsvc.exe is missing in %s. One of them is required in order to install Windows firstboot scripts. You can get one by building rhsrvany (https://github.com/rwmjones/rhsrvany)") > + virt_tools_data_dir > + ) in ( There's a stray ( here, and lots of code gets reindented for reasons I don't understand but may be connected to that stray (. > + g#hivex_commit None; > + g#hivex_close (); > + > + firstboot_dir > + ) End of the stray ) and reformatting. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat...

On Thu, Nov 16, 2017 at 09:26:54PM -0600, Eric Blake wrote: > In preparation for parallel processing, we need to be sure that > two threads belonging to the same connection cannot interleave > their I/O except at message boundaries. Add a mutex around > all reads and writes that must occur as a group (for now, there > is no contention for either mutex). > > Signed-off-by:

...it is not > if ( __get_cpu_var(poll_bankmask) == NULL ) > ^~ > > I was unable to reproduce (xen builds cleanly for me with "6.0.0 20160117 > (experimental) [trunk revision 232481]") but looking at the code the issue > above is clearly real. > > Correctly reindent the if statement. > > This file uses Linux coding style (infact the use of Xen style for > this line is the root cause of the wanring) so use tabs and while > there remove the whitespace inside the if as Linux does. > > [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166...

...is patch, but it might be easier to use > an attribute((cleanup)) handler to deal with the unlocking. See these > links for how we do it in libguestfs: Oh cool! Yes, that looks nicer. Although the diffstat for doing so is larger, because it requires adding to new sub-function {} scopes and reindenting (we have two different locks in play here). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

...; an attribute((cleanup)) handler to deal with the unlocking. See these >>> links for how we do it in libguestfs: >> >> Oh cool! Yes, that looks nicer. Although the diffstat for doing so is >> larger, because it requires adding to new sub-function {} scopes and >> reindenting (we have two different locks in play here). >> > > Interestingly, it doesn't compile if you lack attribute((cleanup)). > Libguestfs has: > > common/utils/cleanups.h:/* XXX no safe equivalent to > CLEANUP_GL_RECURSIVE_LOCK_UNLOCK */ > > and will fail to compil...

Do CentOS 5.4 users still have to use the RedHat preliminary kernels (http://people.redhat.com/jlayton/) for getting a NFSv4 safe kernel or have the patches been incorporated into CentosPlus kernels? Or is kernel-2.6.18-164.3.1.el5 somewhere in the queue? Thanks in advance! GS -- Gerhard Schneider Institute of Lightweight Design and e-Mail: gs at ilsb.tuwien.ac.at Structural

Reindent with -bad -bap -c0 -cd0 -cp0 -ncdb -ci4 -cli0 -ncs -d0 -di4 -i4 -ip4 -l80 -npcs -psl -sob -ss -ce -sc -br -cdw -lp -cbi0. Bug #6286: Fix build on Cygwin. (Yaakov Selkowitz) Bug #5628 <https://bugs.freedesktop.org/show_bug.cgi?id=5628> Shadow pages not created correctly when MANDIR & MAN...

...ity: enhancement Priority: P5 Component: default AssignedTo: netfilter-buglog at lists.netfilter.org ReportedBy: bochecha at fedoraproject.org Estimated Hours: 0.0 Created attachment 414 --> https://bugzilla.netfilter.org/attachment.cgi?id=414 configure: Reindent the --with-kmod checks Looking at the source cod,e it seems all this stuff is only used in the kernel module that is part of the ipset tarball. So the checks shouldn't be run unconditionally. -- Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email ------- You are receiv...

Petr Pikal said: > I am not really a R specialist but for this task I use function: and he pasted his code into the email. I reindented the code, and wrote a fragment to experiment with it. Here it is: --------------------------------------------------------------------------- plot.yy <- function(x, yright, yleft, yleftlim=NULL, yrightlim = NULL, xlab = NULL, yylab=c("",&quot...

...xwayland: Reset scheduled frames after hiding tablet cursor xwayland: Separate DamagePtr into separate window data xwayland: Refactor surface creation into a separate function xwayland: Handle the case of windows being realized before redirection Eric Anholt (2): shm: reindent shm_tmpfile to follow our standards. shm: Pick the shm dir at run time, not build time. Hans de Goede (1): glamor/xwayland: Define EGL_NO_X11 Kyle Brenneman (3): GLX: Add a per-client vendor mapping. GLX: Use the sending client for looking up XID's GLX: Add a fun...

I had originally thought that I'd do a complete audit of the Dovecot's sources this weekend, but looks like I didn't. Hopefully I've been writing good enough code that the "1000 EUR for security hole" offer lasts for a long time. :) This release should fix the SSL parameter regeneration problem. There were two changes that were needed to fix it, but I had forgotten the

...ly on randr_crtc->scanout_pixmap in drmmode_set_scanout_pixmap Always call PixmapStopDirtyTracking in drmmode_set_scanout_pixmap Consume all available udev events at once Require xserver 1.10 or newer Check Xorg version at runtime instead of build time in two places Reindent code in radeon_dri2_create_buffer2 Refactor radeon_mode_hotplug Use pRADEONEnt to find both screens of a GPU in radeon_mode_hotplug Update manpage entry for Option "TearFree" Bump version for 7.8.0 release Qiang Yu (3): Remove RR_Capability_SinkOutput for GP...

https://bugzilla.mindrot.org/show_bug.cgi?id=2361 Bug ID: 2361 Summary: seccomp filter (not only) for aarch64 Product: Portable OpenSSH Version: 6.7p1 Hardware: Other OS: Linux Status: NEW Severity: enhancement Priority: P5 Component: sshd Assignee: unassigned-bugs at

Hi, I was building LLVM with gcc 6.1.1 recently and it was spitting out some warnings relating to misleading indention that caught my eye. This wasn't a fresh build so I may have missed some. I've CC'ed the authors of the potentially misleading lines so they can decide what do about the warnings (if anything). I'm wondering if clang-format is making some inappropriate choices