Hi, I forked the rspec bundle on github and added a new command to it (an Update RSpec Bundle command). I sent a pull request, but haven''t heard back from anyone on it. David, did you get my pull request? Or did it get lost in the black whole of cyberspace? (if you were too busy to respond, that''s fine, just wanted to follow up) Thanks, Tim
On Fri, Apr 4, 2008 at 3:48 PM, Tim Harper <timcharper at gmail.com> wrote:> Hi, > > I forked the rspec bundle on github and added a new command to it (an > Update RSpec Bundle command). I sent a pull request, but haven''t > heard back from anyone on it. > > David, did you get my pull request? Or did it get lost in the black > whole of cyberspace? (if you were too busy to respond, that''s fine, > just wanted to follow up) > > Thanks, > Tim > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >I think the preferred method is to file a ticket on lighthouse with a link to the relevant commit. Pat
Tim Harper wrote:> Hi, > > I forked the rspec bundle on github and added a new command to it (an > Update RSpec Bundle command). I sent a pull request, but haven''t > heard back from anyone on it. > > David, did you get my pull request? Or did it get lost in the black > whole of cyberspace? (if you were too busy to respond, that''s fine, > just wanted to follow up) > > Thanks, > Tim > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >Hey Tim, I just asked about the use of pull request vs patches on the dev list. According to David things should still be added to the project tracker: http://rspec.lighthouseapp.com/ So you can either upload a patch there or just give the commit link on github he could pull from. Either way they want to keep track of this stuff on lighthouse I think. Also, there was some talk of moving the bundle in a separate bundle and using git modules... I don''t think that has happened yet though... -Ben
On Fri, Apr 4, 2008 at 4:54 PM, Ben Mabey <ben at benmabey.com> wrote:> > Tim Harper wrote: > > Hi, > > > > I forked the rspec bundle on github and added a new command to it (an > > Update RSpec Bundle command). I sent a pull request, but haven''t > > heard back from anyone on it. > > > > David, did you get my pull request? Or did it get lost in the black > > whole of cyberspace? (if you were too busy to respond, that''s fine, > > just wanted to follow up) > > > > Thanks, > > Tim > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > Hey Tim, > I just asked about the use of pull request vs patches on the dev list. > According to David things should still be added to the project tracker: > http://rspec.lighthouseapp.com/ > > So you can either upload a patch there or just give the commit link on > github he could pull from. Either way they want to keep track of this > stuff on lighthouse I think.Ideal way is to give a commit link.> Also, there was some talk of moving the bundle in a separate bundle and > using git modules... I don''t think that has happened yet though...David actually made all these changes last night. If you go to http://github.com/dchelimsky you can see all the repositories. To get the latest and greatest version of the code, do git clone git://github.com/dchelimsky/rspec-dev.git cd rspec-dev git submodule init git submodule update And you''re all set. So Tim, you should check out the latest code (or perhaps just the TM bundle, if you want), create your patch, and then submit a ticket on lighthouse with a link to the commit. Pat
Created: http://rspec.lighthouseapp.com/projects/5645/tickets/365-feature-rspec-bundle-update-rspec-bundle Thanks everyone! Tim On Fri, Apr 4, 2008 at 6:05 PM, Pat Maddox <pergesu at gmail.com> wrote:> On Fri, Apr 4, 2008 at 4:54 PM, Ben Mabey <ben at benmabey.com> wrote: > > > > Tim Harper wrote: > > > Hi, > > > > > > I forked the rspec bundle on github and added a new command to it (an > > > Update RSpec Bundle command). I sent a pull request, but haven''t > > > heard back from anyone on it. > > > > > > David, did you get my pull request? Or did it get lost in the black > > > whole of cyberspace? (if you were too busy to respond, that''s fine, > > > just wanted to follow up) > > > > > > Thanks, > > > Tim > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > Hey Tim, > > I just asked about the use of pull request vs patches on the dev list. > > According to David things should still be added to the project tracker: > > http://rspec.lighthouseapp.com/ > > > > So you can either upload a patch there or just give the commit link on > > github he could pull from. Either way they want to keep track of this > > stuff on lighthouse I think. > > Ideal way is to give a commit link. > > > > > Also, there was some talk of moving the bundle in a separate bundle and > > using git modules... I don''t think that has happened yet though... > > David actually made all these changes last night. If you go to > http://github.com/dchelimsky you can see all the repositories. > > To get the latest and greatest version of the code, do > git clone git://github.com/dchelimsky/rspec-dev.git > cd rspec-dev > git submodule init > git submodule update > > And you''re all set. > > So Tim, you should check out the latest code (or perhaps just the TM > bundle, if you want), create your patch, and then submit a ticket on > lighthouse with a link to the commit. > > Pat > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >