ADIL ARUN DANGUI via llvm-dev
2018-Jan-02 08:56 UTC
[llvm-dev] https://reviews.llvm.org/D41659 Needs review.
https://reviews.llvm.org/D41659 Implemented missing trigonometric optimization in llvm. Here we have implemented the following missing trigonometric optimizations. 1. tan(x)*cos(x)=sin(x) 2. sin(x)*cos(x) = sin(2*x)/2 3. sin(x)/tan(x)=cos(x); 4. tan(x)/sin(x)=1/cos(x); -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180102/c81f14f8/attachment.html>
Alex Bradbury via llvm-dev
2018-Jan-02 10:44 UTC
[llvm-dev] https://reviews.llvm.org/D41659 Needs review.
On 2 January 2018 at 08:56, ADIL ARUN DANGUI via llvm-dev <llvm-dev at lists.llvm.org> wrote:> https://reviews.llvm.org/D41659 > > Implemented missing trigonometric optimization in llvm. > > Here we have implemented the following missing trigonometric optimizations. > > tan(x)*cos(x)=sin(x) > sin(x)*cos(x) = sin(2*x)/2 > sin(x)/tan(x)=cos(x); > tan(x)/sin(x)=1/cos(x);Hi Adil - welcome to the LLVM community! The documentation on submitting a patch via Phabricator has some tips on finding code reviewers: <http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface>. Looking in CODE_OWNERS.txt I can see that David Majnemer is code owner for InstCombine, so he should at least be added as a reviewer. Looking at commits to InstructionCombining.cpp it looks like Craig Topper may be another appropriate reviewer. Unless the patch is particularly controversial (this requiring an RFC or wider community feedback), you're best to add llvm-commits and reviewers following the above guidance, then wait for a week or so. If you're not getting any response after a couple of pings then it may be worth bringing it to the mailing list. I also try to highlight patches that are either stuck awaiting review or from first time contributors in the "Review Corner" section of LLVM Weekly. More info and a submission form here: http://llvmweekly.org/reviewcorner I hope that helps, Alex
Seemingly Similar Threads
- A Study on "Dependence capturing strength" of four Dependence Analyzers in LLVM on SPEC 2017 benchmarks
- About trigonometric Instructions
- trigonometric regression
- using its to import time series data with uneven dates
- [RFC] 'Review corner' section in LLVM Weekly