llvm dev - Nov 2017 - Problem with 'sed' on one Windows bot?

A test I added in r317607 is passing almost everywhere, except for
llvm-clang-x86_64-expensive-checks-win.  Other Windows bots are happy.

http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6013

The test runs 'sed' on a file to generate variations of the input
assembler source for Linux and Darwin.  I have to say it looks like
'sed' is being the problem on that one bot.  I reverted the test
because "don't argue with the bots" but... but... "It's
not my fault!"

If anybody has any insight it would be greatly appreciated.
Thanks,
--paulr

The failure is this:

Command Output (stdout):
--
$ "sed" "-E" "s/@ELF@(.*)/\1/;s/@MACHO@(.*)//"
"C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\test\DebugInfo\X86\dwarfdump-header-64.s"
$
"C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build\bin\llvm-mc.EXE"
"-triple" "x86_64-unknown-linux" "-filetype=obj"
"-o" "-"
# command stderr:
<stdin>:17:1: error: unexpected token at start of statement

1

^

<stdin>:28:1: error: unexpected token at start of statement

1

^

<stdin>:43:1: error: unexpected token at start of statement

1

^

<stdin>:53:1: error: unexpected token at start of statement

1

^

<stdin>:59:1: error: unexpected token at start of statement

1

^

<stdin>:71:1: error: unexpected token at start of statement

1

^


error: command failed with exit status: 1

"Robinson, Paul via llvm-dev" <llvm-dev at lists.llvm.org>
writes:
> A test I added in r317607 is passing almost everywhere, except for
> llvm-clang-x86_64-expensive-checks-win.  Other Windows bots are happy.
>
>
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6013
>
> The test runs 'sed' on a file to generate variations of the input
> assembler source for Linux and Darwin.  I have to say it looks like
> 'sed' is being the problem on that one bot.  I reverted the test
> because "don't argue with the bots" but... but...
"It's not my fault!"
>
> If anybody has any insight it would be greatly appreciated.
> Thanks,
> --paulr
>
> The failure is this:
>
> Command Output (stdout):
> --
> $ "sed" "-E"
"s/@ELF@(.*)/\1/;s/@MACHO@(.*)//"
"C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\test\DebugInfo\X86\dwarfdump-header-64.s"
Looks to me like the the \1 is being interpreted as an escape and you're
getting a literal "1" instead of the substitution. Given that there
are
double-quotes here that sort of makes sense, though the commit clearly
used single quotes, so that's odd. Maybe there's something funny about
how lit is passing this to whatever shell?

In any case, presumably `sed -e 's/@ELF@//; s/@MACHO@(.*)//'` would work
around that - since you're capturing the rest of the line you don't
really need the backreference anyway.
> $
"C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build\bin\llvm-mc.EXE"
"-triple" "x86_64-unknown-linux" "-filetype=obj"
"-o" "-"
> # command stderr:
> <stdin>:17:1: error: unexpected token at start of statement
>
> 1
>
> ^
>
> <stdin>:28:1: error: unexpected token at start of statement
>
> 1
>
> ^
>
> <stdin>:43:1: error: unexpected token at start of statement
>
> 1
>
> ^
>
> <stdin>:53:1: error: unexpected token at start of statement
>
> 1
>
> ^
>
> <stdin>:59:1: error: unexpected token at start of statement
>
> 1
>
> ^
>
> <stdin>:71:1: error: unexpected token at start of statement
>
> 1
>
> ^
>
>
> error: command failed with exit status: 1
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

On Tue, Nov 7, 2017 at 2:41 PM, Robinson, Paul via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> A test I added in r317607 is passing almost everywhere, except for
> llvm-clang-x86_64-expensive-checks-win.  Other Windows bots are happy.
>
>
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6013
>
> The test runs 'sed' on a file to generate variations of the input
> assembler source for Linux and Darwin.  I have to say it looks like
> 'sed' is being the problem on that one bot.  I reverted the test
> because "don't argue with the bots" but... but...
"It's not my fault!"
>
> If anybody has any insight it would be greatly appreciated.
> Thanks,
> --paulr
>
The short answer is that Galina should install the correct version of
`sed` (presumably from gnuwin32) on that bot.
The somewhat longer answer is that you could work around as Justin
suggested, but I'm not sure what's your sed foo and/or whether it's
worth going that route.

On Tue, Nov 7, 2017 at 3:10 PM, Davide Italiano <davide at freebsd.org>
wrote:
> On Tue, Nov 7, 2017 at 2:41 PM, Robinson, Paul via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
>> A test I added in r317607 is passing almost everywhere, except for
>> llvm-clang-x86_64-expensive-checks-win.  Other Windows bots are happy.
>>
>>
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6013
>>
>> The test runs 'sed' on a file to generate variations of the
input
>> assembler source for Linux and Darwin.  I have to say it looks like
>> 'sed' is being the problem on that one bot.  I reverted the
test
>> because "don't argue with the bots" but... but...
"It's not my fault!"
>>
>> If anybody has any insight it would be greatly appreciated.
>> Thanks,
>> --paulr
>>
>
> The short answer is that Galina should install the correct version of
> `sed` (presumably from gnuwin32) on that bot.
> The somewhat longer answer is that you could work around as Justin
> suggested, but I'm not sure what's your sed foo and/or whether
it's
> worth going that route.
Side note: in my early days on Windows years ago I spent a good couple
of hours trying to figure out why some tests were failing, to discover
I had installed the wrong tool.
I don't recall whether the documentation points to the one true
version of sed/awk/* required, but in case it doesn't, maybe we might
consider adding it?

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare

As Davide suggests, most likely it's a bot software installation snafu.
But the simpler sed script works perfectly, and I'll do that for now.

I had understood that LLVM expected people to install GnuWin32, but
maybe it's not sufficiently well specified about versions and whatnot.
--paulr
> -----Original Message-----
> From: davide.italiano at gmail.com [mailto:davide.italiano at gmail.com] On
> Behalf Of Davide Italiano
> Sent: Tuesday, November 07, 2017 3:10 PM
> To: Robinson, Paul; Galina Kistanova
> Cc: llvm-dev at lists.llvm.org
> Subject: Re: [llvm-dev] Problem with 'sed' on one Windows bot?
> 
> On Tue, Nov 7, 2017 at 2:41 PM, Robinson, Paul via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> > A test I added in r317607 is passing almost everywhere, except for
> > llvm-clang-x86_64-expensive-checks-win.  Other Windows bots are happy.
> >
> > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-
> win/builds/6013
> >
> > The test runs 'sed' on a file to generate variations of the
input
> > assembler source for Linux and Darwin.  I have to say it looks like
> > 'sed' is being the problem on that one bot.  I reverted the
test
> > because "don't argue with the bots" but... but...
"It's not my fault!"
> >
> > If anybody has any insight it would be greatly appreciated.
> > Thanks,
> > --paulr
> >
> 
> The short answer is that Galina should install the correct version of
> `sed` (presumably from gnuwin32) on that bot.
> The somewhat longer answer is that you could work around as Justin
> suggested, but I'm not sure what's your sed foo and/or whether
it's
> worth going that route.