Fedor Sergeev via llvm-dev
2017-Dec-13 22:06 UTC
[llvm-dev] instcombine and alias analysis (new-PM)
Folks, I have recently stumbled on the following bizarre comment in InstCombinePass::run : // FIXME: The AliasAnalysis is not yet supported in the new pass manager with subsequent nullptr instead of AliasAnalysis proper. Is there any reason on why we do not pass an actual AliasAnalisys instead of that nullptr? Here is patch that does this: https://reviews.llvm.org/D41203 regards, Fedor.
Chandler Carruth via llvm-dev
2017-Dec-14 02:26 UTC
[llvm-dev] instcombine and alias analysis (new-PM)
Closing the loop (Already replied to patch) I think this is just an oversight since the AA support landed. Thanks for fixing! On Wed, Dec 13, 2017 at 2:06 PM Fedor Sergeev via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Folks, > > I have recently stumbled on the following bizarre comment in > InstCombinePass::run : > // FIXME: The AliasAnalysis is not yet supported in the new pass > manager > with subsequent nullptr instead of AliasAnalysis proper. > > Is there any reason on why we do not pass an actual AliasAnalisys > instead of that nullptr? > Here is patch that does this: https://reviews.llvm.org/D41203 > > regards, > Fedor. > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20171214/b4c5eda0/attachment.html>