rsync - Feb 2014 - [Bug 10450] New: --info=progress2 increase %

https://bugzilla.samba.org/show_bug.cgi?id=10450

           Summary: --info=progress2 increase %
           Product: rsync
           Version: 3.1.0
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: vania.toperich at gmail.com
         QAContact: rsync-qa at samba.org


--info=progress2 will not show increase of percentage done in real time as
current throughput will. Percentage get's updated only after file has been
transferred to destination. If you have 4 files you will get only 4 updates
(jumps) of bandwidth %

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10450

--- Comment #1 from Anish Shankar <rndanish at gmail.com> 2014-02-16
04:18:39 UTC ---
Created attachment 9689
  --> https://bugzilla.samba.org/attachment.cgi?id=9689
suggested patch

I actually posted about the same a while back on the list, but was't sure if
it
was expected behaviour (I would think not), or a bug. I made a patch which
appears to fix this issue for most of my use cases and have been using this for
a while now. From what I've seen this should fix bug 10451 as well.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10450

--- Comment #2 from Anish Shankar <rndanish at gmail.com> 2014-02-16
04:22:04 UTC ---
(In reply to comment #0)
>Percentage get's updated only after file has been transferred to
destination.
>From what I noticed as well as looking the code, I think the percentage
get's
updated *before* the file even gets transferred , hence leading rsync to think
that a huge file has been transferred instantaneously showing very huge
unrealistic bandwidths. There after no more bytes transferred changes till the
next file, causing speed to decay down again.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10450

--- Comment #3 from Vania Toperich <vania.toperich at gmail.com>
2014-02-16 08:46:21 UTC ---
Thanks.. I will try it out.

(In reply to comment #1)
> Created attachment 9689 [details]
> suggested patch
> 
> I actually posted about the same a while back on the list, but was't
sure if it
> was expected behaviour (I would think not), or a bug. I made a patch which
> appears to fix this issue for most of my use cases and have been using this
for
> a while now. From what I've seen this should fix bug 10451 as well.
-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10450

--- Comment #4 from Vania Toperich <vania.toperich at gmail.com>
2014-02-16 09:34:13 UTC ---
Yes it works perfectly. Thanks a lot.. Also speed is correct as well (it
settles to correct value)

Have a nice day

(In reply to comment #3)
> Thanks.. I will try it out.
> 
> (In reply to comment #1)
> > Created attachment 9689 [details] [details]
> > suggested patch
> > 
> > I actually posted about the same a while back on the list, but
was't sure if it
> > was expected behaviour (I would think not), or a bug. I made a patch
which
> > appears to fix this issue for most of my use cases and have been using
this for
> > a while now. From what I've seen this should fix bug 10451 as
well.
-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10450

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Wayne Davison <wayned at samba.org> 2014-02-24
18:04:43 UTC ---
Thanks for the patch!  I think this makes the output much nicer.  I have
applied it in the git repo for the next release.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.