rsync - Nov 2013 - [Bug 10295] New: do_lchown() after set_xattr() causes xattrs to be dropped on Linux 3.10.20.

https://bugzilla.samba.org/show_bug.cgi?id=10295

           Summary: do_lchown() after set_xattr() causes xattrs to be
                    dropped on Linux 3.10.20.
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: caowasteland at gmail.com
         QAContact: rsync-qa at samba.org


Created attachment 9489
  --> https://bugzilla.samba.org/attachment.cgi?id=9489
Candidate patch on rsync 3.1.0.  Please review.

Example:

    rsync -Xa /foo /bar

Expected:

    Copies will have the same security attributes as the originals.

Reality:

    Copies have security attributes cleared.

Please look at rsync-3.1.0/rsync.c lines 492 & 541 in the context of
chown_common() from linux kernel fs/open.c around the 500th line.  It appears
that the SET{G,U}ID bits and security attrs are cleared.

Relevant kernel line:

        if (!S_ISDIR(inode->i_mode))
                newattrs.ia_valid |                        ATTR_KILL_SUID |
ATTR_KILL_SGID | ATTR_KILL_PRIV;


Suggestion: move the SUPPORT_XATTRS code invocation after the if (change_uid...
block.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10295

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9489|0                           |1
           is patch|                            |
   Attachment #9489|application/octet-stream    |text/plain
          mime type|                            |

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10295

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Wayne Davison <wayned at samba.org> 2013-11-28
21:06:05 UTC ---
The xattr-setting code was moved prior to the mtime setting due to some
instances of xattr-setting tweaking it (e.g. os x resource fork info).  So, to
move it elsewhere, we'll need to change the xattr code (which currently
signals
the time-setting code when it thinks that the mtime might have been tweaked).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10295

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #2 from Wayne Davison <wayned at samba.org> 2013-11-28
21:20:28 UTC ---


*** This bug has been marked as a duplicate of bug 10163 ***

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.