search for: do_lchown

https://bugzilla.samba.org/show_bug.cgi?id=10295 Summary: do_lchown() after set_xattr() causes xattrs to be dropped on Linux 3.10.20. Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: core Assign...

...************* *** 110,116 **** rprintf(FERROR,"make_bak_dir stat %s : %s\n",fullpath,strerror(errno)); } else { st2=&st; ! set_modtime(fullpath,st2->st_mtime); if(do_lchown(fullpath,st2->st_uid,st2->st_gid)!=0) { rprintf(FERROR,"make_bak_dir chown %s : %s\n",fullpath,strerror(errno)); }; --- 110,117 ---- rprintf(FERROR,"make_bak_dir stat %s : %s\n",fullpath,...

...ar *fnamecmp, int flags); > RETSIGTYPE sig_int(UNUSED(int val)); > @@ -293,11 +295,12 @@ int sock_exec(const char *prog); > int do_unlink(const char *fname); > int do_symlink(const char *fname1, const char *fname2); > int do_link(const char *fname1, const char *fname2); > -int do_lchown(const char *path, uid_t owner, gid_t group); > +int do_lchown(const char *path, uid_t owner, gid_t group, mode_t > mode, uint32 fileflags); > int do_mknod(const char *pathname, mode_t mode, dev_t dev); > int do_rmdir(const char *pathname); > int do_open(const char *pathname, int...

...e- root', they wrap their use of stat/chown to grab/modify the uid/gid/ rdev/mode from/to xattrs of the form user.rsync.fake- {uid,gid,mode,rdev}. The EA code would also silently drop EAs of those names. This seems to me like a pretty easy change that would be quite useful. do_mknod and do_lchown are already wrapppers. The hardest part would be tracking down all the uses of stat/fstat/etc and wrapping them. What do others think? If people like this, I'll write it. If people have a better suggestion, let me know, because I need to solve this!

hello- i am using rsync via ssh to maintain a copy of a few directories on a remote server, and am getting an error when rsync tries to chmod a certain file following it's transfer. there are a couple of cases in which this occurring - below is one example. local machine is debian testing - rsync version 2.6.3 protocol version 28 remote machine is macos x 10.3.7 - rsync version 2.6.2

...Mar 2004 20:18:03 -0000 1.28 +++ backup.c 10 Apr 2004 23:28:35 -0000 @@ -101,7 +101,7 @@ "make_bak_dir stat %s failed: %s\n", full_fname(rel), strerror(errno)); } else { - set_modtime(fullpath, st.st_mtime); + set_times(fullpath, st.st_mtime, time(NULL)); do_lchown(fullpath, st.st_uid, st.st_gid); do_chmod(fullpath, st.st_mode); } Index: batch.c =================================================================== RCS file: /cvsroot/rsync/batch.c,v retrieving revision 1.31 diff -u -w -r1.31 batch.c --- batch.c 6 Mar 2004 07:45:52 -0000 1.31 +++ batch.c...

...Mar 2004 20:18:03 -0000 1.28 +++ backup.c 20 Apr 2004 21:06:17 -0000 @@ -101,7 +101,7 @@ "make_bak_dir stat %s failed: %s\n", full_fname(rel), strerror(errno)); } else { - set_modtime(fullpath, st.st_mtime); + set_times(fullpath, st.st_mtime, time(NULL)); do_lchown(fullpath, st.st_uid, st.st_gid); do_chmod(fullpath, st.st_mode); } Index: batch.c =================================================================== RCS file: /cvsroot/rsync/batch.c,v retrieving revision 1.31 diff -u -w -r1.31 batch.c --- batch.c 6 Mar 2004 07:45:52 -0000 1.31 +++ batch.c...

...ode); if (ret < 0) { rsyserr(FERROR_XFER, errno, "failed to set times on %s", @@ -423,6 +472,9 @@ int set_file_attrs(const char *fname, st } } if (am_root >= 0) { +#ifdef SUPPORT_FLAGS + make_mutable(fname, sxp->st.st_mode, sxp->st.st_flags); +#endif if (do_lchown(fname, change_uid ? (uid_t)F_OWNER(file) : sxp->st.st_uid, change_gid ? (gid_t)F_GROUP(file) : sxp->st.st_gid) != 0) { @@ -457,7 +509,13 @@ int set_file_attrs(const char *fname, st #ifdef HAVE_CHMOD if (!BITS_EQUAL(sxp->st.st_mode, new_mode, CHMOD_BITS)) { - int ret =...