rsync - Sep 2013 - [Bug 10163] New: rsync -X is ineffective when setting owner/group

https://bugzilla.samba.org/show_bug.cgi?id=10163

           Summary: rsync -X is ineffective when setting owner/group
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: mluscon at redhat.com
         QAContact: rsync-qa at samba.org


Created attachment 9236
  --> https://bugzilla.samba.org/attachment.cgi?id=9236
Patch

Description of problem:
rsync -X preserves extended attributes on files. It works partially; however,
if combined with rsync options which preserve the file owner and/or group, it
is partially ineffective. This is because rsync calls chown(2) after setting
attributes, and chown removes security attributes (as in capabilities(5)).
Steps to Reproduce:

$ touch foo
$ sudo setcap cap_dac_read_search=pe foo
$ getcap foo
foo = cap_dac_read_search+ep
$ sudo rsync -X foo foo.1
$ getcap foo.1
foo.1 = cap_dac_read_search+ep
$ sudo rsync -aX foo foo.2
$ getcap foo.2
$

This report originates from https://bugzilla.redhat.com/show_bug.cgi?id=981797

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10163

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caowasteland at gmail.com

--- Comment #1 from Wayne Davison <wayned at samba.org> 2013-11-28
21:20:28 UTC ---
*** Bug 10295 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10163

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9236|0                           |1
        is obsolete|                            |

--- Comment #2 from Wayne Davison <wayned at samba.org> 2013-11-28
21:28:09 UTC ---
Created attachment 9492
  --> https://bugzilla.samba.org/attachment.cgi?id=9492
Move xattr-setting after chowning.

Here's a patch I'm considering that also moves the mtime-setting code,
along
with the xattr-setting code (so that the modify time still gets set after
setting xattrs).  Please do some testing and see if anything breaks.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10163

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Wayne Davison <wayned at samba.org> 2013-12-23
17:50:05 UTC ---
I've committed my proposed patch.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.