Puppet users - Jul 2013 - Enhancement to puppetlabs-vcsrepo

Hello!  I was looking at using the puppetlabs-vcsrepo module for a project,
but it seems to be missing a feature I need.  Specifically, I need to be
able to do one of the following two things:
svn cat URL > FILENAME
svn export URL

Looking at the code, they do not seem supported.  So, after some googling
on modifying providers, I took a stab at it and I added a "export"
parameter.  Attached to the email is my diff.  Keep in mind the following:
1) My Ruby sucks, and probably always will.
2) I''ve never modified a provider before, and I really have no idea
what
I''m doing.

Requests:
1) Am I going about this the right way?
2) Any suggestions as to how to do it better?

As per the suggestions in the "Module Contributing" wiki page,
I''m coming
here for suggestions/abuse before going further.

Thanks!
Jeffrey.

P.S.  It''s been a while since I''ve played with the
"puppet module" command.
 Nice work!  Was very easy.

-- 
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscribe@googlegroups.com.
To post to this group, send email to puppet-users@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-users.
For more options, visit https://groups.google.com/groups/opt_out.

Has anyone had time to look at my diff?

Thanks again,
Jeffrey.


On Fri, Jul 26, 2013 at 4:04 PM, Jeffrey Watts
<jeffrey.w.watts@gmail.com>wrote:
> Hello!  I was looking at using the puppetlabs-vcsrepo module for a
> project, but it seems to be missing a feature I need.  Specifically, I need
> to be able to do one of the following two things:
> svn cat URL > FILENAME
> svn export URL
>
> Looking at the code, they do not seem supported.  So, after some googling
> on modifying providers, I took a stab at it and I added a
"export"
> parameter.  Attached to the email is my diff.  Keep in mind the following:
> 1) My Ruby sucks, and probably always will.
> 2) I''ve never modified a provider before, and I really have no
idea what
> I''m doing.
>
> Requests:
> 1) Am I going about this the right way?
> 2) Any suggestions as to how to do it better?
>
> As per the suggestions in the "Module Contributing" wiki page,
I''m coming
> here for suggestions/abuse before going further.
>
> Thanks!
> Jeffrey.
>
> P.S.  It''s been a while since I''ve played with the
"puppet module"
> command.  Nice work!  Was very easy.
>
-- 
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscribe@googlegroups.com.
To post to this group, send email to puppet-users@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-users.
For more options, visit https://groups.google.com/groups/opt_out.