compiz - Sep 2006 - initial metacity theme support for compiz

I just pushed some code into the compiz repository for initial metacity
theme support. It's not complete, left and right borders are not
rendered correctly, button decorations doesn't always match event window
locations, maximized and shaded windows are not rendered as when running
metacity, button locations are not configurable as with metacity... but
it still seem to look OK with most themes.

I've created a libmetacity, which you'll need to build this for now but
I think it makes more sense to just have this as part of metacity
itself. My current libmetacity hack contains the necessary source code
files from metacity CVS (completely unmodified) and a pkgconfig file.
I'd very much like to update libmetacity with the theme rewrite that is
is under way but it would be nicer to get the changes I need for a
libmetacity into the metacity code base and get the theme rewrite once
it's merged.

You can get libmetacity from here:
http://people.freedesktop.org/~davidr/libmetacity-1.tar.bz2

Once you've built gwd with metacity support you'll need to do:

gconftool-2 -s /apps/gwd/use_metacity_theme -t bool true

to enable use of metacity themes. gnome-theme-manager should work fine
for selecting themes.

The things I mentioned above that aren't working yet shouldn't take to
long to fix. I'll try to get the most important ones fixed when I have
time but I someone beats me to it, I'd be more than happy. I also don't
think all of them necessarily needs to be done before the compiz
release.

-David

On 9/22/06, David Reveman <davidr@novell.com>
wrote:
> I just pushed some code into the compiz repository for initial metacity
> theme support.
That's the great news, however with cow patch and libmetacity
requiring gtk 2.10, SLED10 and openSUSE 10.1 users will not be able to
build/use it. They come with gtk 2.8. Any chance that it would be
compatible with it in near future?

Thanks

-J
__________
cyberorg

On 9/22/06, Jigish Gohil <jigish.gohil@gmail.com>
wrote:
> On 9/22/06, Jigish Gohil <jigish.gohil@gmail.com> wrote:
> > On 9/22/06, David Reveman <davidr@novell.com> wrote:
> >
> > >
> > > The cow patch is still defaulting to using the root window so it
should
> > > work fine on openSUSE 10.1, SLED10.
> >
> > It doesnt build with cow patch.
> >
> > I had to change the following to make it build, may be we need
> > configure time option like --disable-cow.
> >
> > #############patch#############
> > --- compiz/src/screen.c 2006-09-22 14:14:33.000000000 +0530
> > +++ /usr/src/packages/BUILD/compiz/src/screen.c 2006-09-22
> > 17:16:15.000000000 +0530
> > @@ -897,7 +897,7 @@
> >      Display       *dpy = s->display->display;
> >      XserverRegion region;
> >
> > -    s->overlay   = XCompositeGetOverlayWindow (dpy, s->root);
> > +    s->overlay = s->output = s->root;
> >      s->output    = s->overlay;
> >
> >      region = XFixesCreateRegion (dpy, NULL, 0);
> > ##########end patch##############
> >
> >
> > > I don't think the code in libmetacity
> > > really requires gtk 2.10, I just copied the pkgconfig requirement
line
> > > from metacity so that's why it's 2.10 right now. Try
changing it to 2.8
> > > and see if it works. Now that you mention it, I realize that I
added
> > > something that might be gtk 2.10 specific (a call to
> > > gdk_screen_get_rgba_colormap) to gwd, I can easily workaround
that
> > > though.
> >
> > Yes there are some bits that uses gtk 2.10 in there, but that is
> > libmetacity > 2.12 that ships with SLED and 10.1.
> >
> > >
> > > So the answer to your question is; Yes, I'll make sure
it's compatible
> >
> David
>
> IT WORKS!!!, so I guess that saves extra effort needed to make it
> compatible with 10.1.
>
> Thanks gandalfin for your patch, that and the nocow patch did it.
>
> I can confirm, themed compiz works with metacity 2.12, xorg 6.9 on
> SLED 10, flawlessly.
>
> Awsome work!!
>
> -J
>
PS. Forgot to hit reply all button.


-- 
CyberOrg Info
Novell & IBM Partner
7 FF Unad Deep, Tower A
Susen Tarsali Road
Vadodara 390 009
T. +91 265 3042956 M +91 9898092956
Web. http://www.cyberorg.info