David Reveman
2006-Sep-20 09:13 UTC
[compiz] metacity theme support in gnome-window-decorator
I played a little bit yesterday with adding metacity theme support to gwd and it looks like it's not going to be very hard. Hopefully I'll have it working in the next couple of days. What I've done is to rip out all the parts of the metacity code that is required for theme support (boxes.c, gradient.c, theme-parser.c, theme.c, util.c). Ideal would be if we could put this part of metacity in a libmetacity so it can be shared between gwd and metacity. Does that sound reasonable? I'll post some more details about this once I have it actually working. -David
Elijah Newren
2006-Sep-20 09:56 UTC
[compiz] Re: metacity theme support in gnome-window-decorator
On 9/20/06, David Reveman <davidr@novell.com> wrote:> I played a little bit yesterday with adding metacity theme support to > gwd and it looks like it's not going to be very hard. Hopefully I'll > have it working in the next couple of days. What I've done is to rip out > all the parts of the metacity code that is required for theme support > (boxes.c, gradient.c, theme-parser.c, theme.c, util.c). Ideal would be > if we could put this part of metacity in a libmetacity so it can be > shared between gwd and metacity. Does that sound reasonable? > > I'll post some more details about this once I have it actually working.Cool. :) I'm betting you could get away without most of boxes.[ch]. The definition of MetaRectangle plus meta_rectangle_intersect() is probably all that's needed. util.[ch] is probably similar; it's mainly just functions to provide debugging spew (meta_verbose, meta_warning, meta_topic...), you may have similar functions already that you could replace those with (or, if you "don't need no stinkin' debugging logs" just rip them out). It's worth noting that a theme rewrite is under way and will probably be merged soon: http://bugzilla.gnome.org/show_bug.cgi?id=102547. Perhaps you want to include the new version? Anyway, I know nothing about the theme code in metacity (theming has always been the part that is boring to me and which I really don't care about), so if you have questions, Havoc or Thomas would be the best ones to ask. Cheers, Elijah