Hello everyone... :) I liked the idea of having descriptions for various sysctl oid's in -CURRENT, so I have created a patch to merge these over to -STABLE. I am unsure as to how much work has already gone into bringing this to -STABLE, but as the descriptions already exist in the source, I am fairly confident that it was planned at some point. All I can really ask is that someone with more knowledge than myself about the sysctl internals have a brief look at my patch to see if it is viable. On my system (4.8-STABLE), everything seems to work, and there have been no adverse effects from it. (That I am aware of at least) The patch is attached to this email, and is also available at: http://evo6.org/sysctl-mfc.patch I hope someone may find this useful. :) Very best regards, Andy Gilligan -------------- next part -------------- A non-text attachment was scrubbed... Name: sysctl-mfc.patch Type: application/octet-stream Size: 3995 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20030419/9d0b9056/sysctl-mfc.obj
A slight mistake on my part. The patch attached to the previous email did not include the updated sysctl.8 manpage (although the link was correct). The updated patch is attached this time :) - Andy ----- Original Message ----- From: "Andy Gilligan" <andy@evo6.org> To: <stable@freebsd.org> Sent: Saturday, April 19, 2003 3:12 PM Subject: MFC for sysctl descriptions> Hello everyone... :) > > I liked the idea of having descriptions for various > sysctl oid's in -CURRENT, so I have created a patch > to merge these over to -STABLE. > > I am unsure as to how much work has already gone into > bringing this to -STABLE, but as the descriptions > already exist in the source, I am fairly confident that > it was planned at some point. > > All I can really ask is that someone with more knowledge > than myself about the sysctl internals have a brief look > at my patch to see if it is viable. > > On my system (4.8-STABLE), everything seems to work, and > there have been no adverse effects from it. > (That I am aware of at least) > > The patch is attached to this email, and is also available > at: http://evo6.org/sysctl-mfc.patch > > I hope someone may find this useful. :) > > Very best regards, > Andy Gilligan-------------- next part -------------- A non-text attachment was scrubbed... Name: sysctl-mfc.patch Type: application/octet-stream Size: 4658 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20030419/9295b3c9/sysctl-mfc.obj
Yes, it should... I was wondering about this myself. Although, it is also just called 'descr' in -CURRENT, and I was initially unsure if this would have any impact on the rest of the kernel. After delving a little deeper I see no reason for it to be kept as 'descr', so I have modified the patch accordingly. I have just recompiled my own kernel, with the 'oid_descr' field changes and everything seems to be ok. Best regards, - Andy ----- Original Message ----- From: "Gregory Neil Shapiro" <gshapiro@freebsd.org> To: "Andy Gilligan" <andy@evo6.org> Sent: Saturday, April 19, 2003 5:15 PM Subject: Re: MFC for sysctl descriptions> One comment on the patch: > > --- sys/sys/sysctl.h 9 Sep 2002 19:27:54 -0000 1.81.2.9 > +++ sys/sys/sysctl.h 19 Apr 2003 13:24:38 -0000 > @@ -133,6 +133,7 @@ > int (*oid_handler)(SYSCTL_HANDLER_ARGS); > const char *oid_fmt; > int oid_refcnt; > + const char *descr; > }; > > Shouldn't that be oid_descr to match the style of the rest of the > structure elements? >