Nut upsdev - Feb 2012 - Submitting updated driver

From private E-mail:
> > My question to you is how I should go about getting
> > the changes back into the system. My work has been exclusively on the
ONEAC
> > driver and man page.  The driver .c file is almost completely redone.
>
>how can you warrant compat?
>Ie, if it's a full rewrite, what have you done to ensure that
>currently supported devices will still be supported, without
>regression?
>this is something crucial, and whenever we have a doubt, we use the
>"new<drv-name>" approach to allow testing/feedback, and
still provide
>a mature fallback method
I should have said it is a significant addition of both available 
data, commands and settable things.  Yes, the way it talks to the 
serial port has also changed a bit but most of what was in the driver 
is still there.  What has been added is getting more out of the 
existing protocol and adding some new protocol possibilities based on 
a positive UPS identification.

At what point does it make sense to submit a new driver versus a diff?

A new driver seems to touch on more pieces of the system...for 
instance I have not been able to get an oneac-new.c file to be built 
using make yet.  What all needs to be modified to add it to the 
system or does that need to be done by Arnaud et al?

Should the man page be a completely different one if I am going to 
submit a new driver or just add the comments that cover the new driver?

Sorry to be asking so many questions...but this is the first time 
I've touched the NUT system.

Thanks,

Bill
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20120227/d2b562f4/attachment.html>

Hi Bill

2012/2/27 William R. Elliot <bill at
wreassoc.com>:
> From private E-mail:
>
>> My question to you is how I should go about getting
>> the changes back into the system. My work has been exclusively on the
>> ONEAC
>> driver and man page.? The driver .c file is almost completely redone.
>
> how can you warrant compat?
> Ie, if it's a full rewrite, what have you done to ensure that
> currently supported devices will still be supported, without
> regression?
> this is something crucial, and whenever we have a doubt, we use the
> "new<drv-name>" approach to allow testing/feedback, and
still provide
> a mature fallback method
>
>
> I should have said it is a significant addition of both available data,
> commands and settable things.? Yes, the way it talks to the serial port has
> also changed a bit but most of what was in the driver is still there.? What
> has been added is getting more out of the existing protocol and adding some
> new protocol possibilities based on a positive UPS identification.
>
> At what point does it make sense to submit a new driver versus a diff?
>
> A new driver seems to touch on more pieces of the system...for instance I
> have not been able to get an oneac-new.c file to be built using make yet.
> What all needs to be modified to add it to the system or does that need to
> be done by Arnaud et al?
>
> Should the man page be a completely different one if I am going to submit a
> new driver or just add the comments that cover the new driver?
>
> Sorry to be asking so many questions...but this is the first time I've
> touched the NUT system.
the easiest thing to do, for the time being, is to send us what you
already have for review (svn diff, compressed if needed).
following this, we'll comment and help you in finding the right way.

cheers,
Arnaud
-- 
Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/