rsync - Aug 2010 - DO NOT REPLY [Bug 7622] New: Factor out common logic from itemize and unchanged_attrs functions

https://bugzilla.samba.org/show_bug.cgi?id=7622

           Summary: Factor out common logic from itemize and unchanged_attrs
                    functions
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: matt at mattmccutchen.net
         QAContact: rsync-qa at samba.org


There is a lot of logic duplicated between these two functions.  Factoring it
out would make it easier to add support for preserving new attributes and would
cut down on the number of bugs in one function but not the other, such as:

https://lists.samba.org/archive/rsync/2008-March/020276.html
bug 7618


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7622

--- Comment #1 from Matt McCutchen <matt at mattmccutchen.net> 2011-06-26
20:46:51 UTC ---
Created attachment 6630
  --> https://bugzilla.samba.org/attachment.cgi?id=6630
Patch

W00t!  My first patch since about a year ago!  Also in my repository at
https://mattmccutchen.net/rsync/rsync.git/?a=commitdiff;h=ddc5ae3d9e6cc632b93bac327b6f92d0545b0537
.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.