rsync - Sep 2008 - log format '%P' only logs '/' when use chroot = true

The subject says it all :-)
Apparently in pre-3.0.0 versions '%P' would log the actual path as
specified in the module entry in rsyncd.conf, but now it's apparently
relative to the chroot...


Paul Slootman

On Wed 10 Sep 2008, Paul Slootman wrote:
> Subject: log format '%P' only logs '/' when use chroot =
true
Hmm, my English is deteriorating...
This would be better:

Subject: log format '%P' logs just '/' when use chroot = true


Paul

On Wed, Sep 10, 2008 at 03:50:46PM +0200, Paul Slootman
wrote:
> Apparently in pre-3.0.0 versions '%P' would log the actual path as
> specified in the module entry in rsyncd.conf, but now it's apparently
> relative to the chroot...
Yeah, that appears to have happened in the security release that added
the ability to have an interior module path inside a chroot (so a
patched 2.6.9 would also be affected).  If the user is not using an
interior-chroot path, then a single-line tweak in log.c would be all
that is needed to avoid the issue.  However, with an interior path, we
need to take extra steps to avoid truncating the input value.

The attached patch should fix things.  It's relative to 3.0.4, but will
also apply with a little twiddling to the 3.1.0dev source (and it should
be easy to patch older versions too).

..wayne..
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mod-path.diff
Type: text/x-diff
Size: 4463 bytes
Desc: not available
Url :
http://lists.samba.org/archive/rsync/attachments/20080910/82b0c2ff/mod-path.bin