rsync - Apr 2008 - DO NOT REPLY [Bug 5401] New: getpassf() should honor strict modes

https://bugzilla.samba.org/show_bug.cgi?id=5401

           Summary: getpassf() should honor strict modes
           Product: rsync
           Version: 3.0.3
          Platform: All
        OS/Version: OS/2
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: steve53@earthlink.net
         QAContact: rsync-qa@samba.org


Porting to platforms without true stat() support would be simpler if getpassf()
(authentic.c) honored the strict modes option.  The code would be similar to
the existing code in get_secret().


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5401


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #1 from wayned@samba.org  2008-04-17 12:48 CST -------
The strict-modes setting is a daemon setting.  The getpassf() function is a
client function, so the two are not related.

It might be nice to have a way to make the client strict -- perhaps a configure
option.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5401





------- Comment #2 from steve53@earthlink.net  2008-04-17 13:12 CST -------
Oops, I forgot to consider that this was a client side issue.

A configure option would be handy.  For now, we will just patch it out with an
#ifdef.

In case you would like to add the OS/2 port to your list of available binaries,
it can be found at

  http://www.smedley.info/os2ports/index.php?page=rsync


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5401





------- Comment #3 from steve53@earthlink.net  2008-06-11 12:29 CST -------
This was reported to the rsync team as

https://bugzilla.samba.org/show_bug.cgi?id=5401

As was pointed out by the maintainers, I goofed on my suggested fix.  What's
really needed is to #ifdef the code based on a configure variable.  If might be
sufficient to just use __OS2__.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.