rsync - Sep 2006 - DO NOT REPLY [Bug 4132] New: Does not delete partial files upon completion of transfer

https://bugzilla.samba.org/show_bug.cgi?id=4132

           Summary: Does not delete partial files upon completion of
                    transfer
           Product: rsync
           Version: 2.6.8
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: mugi@pinesalad.net
         QAContact: rsync-qa@samba.org


Using any partial options (-P, --partial, --partial-dir) an interrupted rsync
does create a partial file, however upon resuming and completion of the
transfer the partial file is not removed.

Steps to reproduce:

1. working and verified rsync setup between two systems

2. run rsync with a somewhat large file in the source dir so you have a chance
to interrupt it, use one of the partial options

Here's my example with a partial and temp directory set in the user (xfer)
that
is running the rsync job:

rsync -av --partial-dir=~xfer/partial --temp-dir=~xfer/tmp /xfer/outbox/*
remoteserver:/xfer/inbox/

I'm putting a 200MB+ file in /xfer/outbox

3. Interrupt rsync with a Ctrl-C

4. Verify partial file is created on the remoteserver (in my example, look in
~xfer/partial directory on the remote server)

5. Run the same rsync command to let it continue/resume

6. Upon completion of the job, look on the remoteserver and you will see the
partial file still exists (again, in my example the ~xfer/partial directory on
the remote server).


I have verified the file remains with any of the partial options and using
directories outside of the rsync tree that is being copied/updated.

2.6.8 source compiled on AIX 5.3
Have also tried cygwin and suse flavors.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4132





------- Comment #1 from mugi@pinesalad.net  2006-09-28 19:19 MST -------
*** Bug 4130 has been marked as a duplicate of this bug. ***


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4132





------- Comment #2 from mugi@pinesalad.net  2006-09-28 19:19 MST -------
*** Bug 4131 has been marked as a duplicate of this bug. ***


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4132


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|Does not delete partial     |temp file not removed on
                   |files upon completion of    |siganl (e.g. SIGINT)
                   |transfer                    |
            Version|2.6.8                       |2.6.7




------- Comment #3 from wayned@samba.org  2006-09-29 14:51 MST -------
It's rsync's temp file that is not being cleaned up, not a "partial
file"
(which is something else in rsync's nomenclature).

Here's my earlier email on the subject, complete with patch:

http://lists.samba.org/archive/rsync/2006-May/015608.html


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.